Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skip changelog] Add gRPC status unwrapping in error feedback #1272

Merged
merged 1 commit into from
Apr 20, 2021
Merged

[skip changelog] Add gRPC status unwrapping in error feedback #1272

merged 1 commit into from
Apr 20, 2021

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Apr 19, 2021 •
edited
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

A small enhancement for future work.

  • What is the current behavior?

feedback.Errorf doesn't unwrap gRPC status errors.

  • What is the new behavior?

feedback.Errorf now unwraps gRPC status errors.

Nope.

  • Other information:

Relates to #1251 .

See how to contribute

@silvanocerza silvanocerza added the type: enhancement Proposed improvement label Apr 19, 2021
@silvanocerza silvanocerza requested a review from a team April 19, 2021 16:01
@silvanocerza silvanocerza self-assigned this Apr 19, 2021
umbynos
umbynos approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"vai figliolo" cit

@silvanocerza silvanocerza merged commit 495a5f1 into master Apr 20, 2021
@silvanocerza silvanocerza deleted the scerza/error-unwrap branch April 20, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umbynos umbynos umbynos approved these changes

Assignees

@silvanocerza silvanocerza

Labels
type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silvanocerza @umbynos