Fix OS X metadata folder not ignored when installing lib from zip #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Fixes a bug when installing libraries from zip.
Installing libraries from zip files with
lib install --zip-file <path_to_zip>will fail if zip has been created on Mac OS X, this happens because the__MACOSXmetadata folder is included in the created zip and not ignored when installing.Same thing happens with the gRPC interface.
__MACOSXmetadata folder is now ignored when installing withlib install --zip-file <path_to_zip>, this fixes the gRPC interface too.titled accordingly?
Nope.
None.
See how to contribute