Add serial number of connected board to board details command #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
requested changes
Mar 10, 2021
|
@per1234 updated, should be good now. |
silvanocerza
force-pushed
the
scerza/board-details-serial-number
branch
from
e34031c
to
1ff36a6
Compare
|
Rebased to fix conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Enhances an existing command with more information.
board details <fqbn>doesn't return the serial number of a connected board with the specified fqbn.Calling
board details <fqbn>when a board with that fqbn is connected that board serial number is returned in the json output and in the gRPC interface function.titled accordingly?
Nope.
None.
See how to contribute