Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fuzzy search to board listall and more information in its json output #1205

Merged
merged 2 commits into from
Mar 4, 2021

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Enhances an existing command.

  • What is the current behavior?

board listall --format json returns an array of json objects containing a board name and its FQBN.
board listall <args> filters the output matching <args> as plain text in the board name.

  • What is the new behavior?

board listall --format json returns an array of json objects containing a board name, its FQBN and the Platforms it belongs too.
The filtering has been enhanced with fuzzy search.

No.

  • Other information:

None.


See how to contribute

Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvanocerza silvanocerza merged commit 1f5706f into master Mar 4, 2021
@silvanocerza silvanocerza deleted the scerza/board-listall-enhance branch March 4, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants