Add RootFolderFiles to gRPC LoadSketchResp #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
force-pushed
the
scerza/sketch-file-list
branch
from
ae897c3
to
f9d751c
Compare
|
Rebased to include integration tests fixes from #1183 |
|
I verified it locally; this is a working solution. Thank you! screencast.2021-02-11.13-48-45.mp4
|
cmaglie
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Adds a new property to a gRPC response.
The gRPC consumers have no way of getting a list of supported files that are in the root folder of a sketch.
The gRPC
LoadSketchResphas now aRootFolderFilesproperty that lists the absolute paths to file in the root folder of a sketch.Nope.
Fixes #1173.
@kittaakos this should help fix arduino/arduino-pro-ide#373.
See how to contribute