Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSON output not printing newline #1091

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Fix JSON output not printing newline #1091

merged 1 commit into from
Dec 1, 2020

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

Fixes all commands output.

  • What is the current behavior?

JSON output doesn't print a newline at the end.

  • What is the new behavior?

JSON output prints a newline at the end.

  • Does this PR introduce a breaking change?

No.

  • Other information:

None.

See how to contribute

@silvanocerza silvanocerza self-assigned this Nov 30, 2020
ubidefeo
ubidefeo approved these changes Nov 30, 2020
View reviewed changes
Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@silvanocerza silvanocerza merged commit 05ce150 into master Dec 1, 2020
@silvanocerza silvanocerza deleted the scerza/json-output-newline branch December 1, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubidefeo ubidefeo ubidefeo approved these changes

Assignees

@silvanocerza silvanocerza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silvanocerza @ubidefeo