Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to board list command to watch for connected and disconnected boards #1032

Merged
merged 2 commits into from
Oct 20, 2020

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?
    Adds a new flag to an existing command.
  • What is the current behavior?
    board list command shows only the connected boards when called.
  • What is the new behavior?
    board list can now be called with the --watch or -w flag to keep it running and print an updated list of connected boards as soon as the discovery tools detects a change.
  • Does this PR introduce a breaking change?
    No.
  • Other information:
    I don't we have a reliable way of testing this with automated tests.

See how to contribute

@silvanocerza silvanocerza merged commit a9c0a97 into master Oct 20, 2020
@silvanocerza silvanocerza deleted the scerza/board-list-watcher branch October 20, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants