Fix platform tool dependency determination #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
approved these changes
Oct 9, 2020
silvanocerza
reviewed
Oct 9, 2020
The platform tool dependency check was giving false negatives due to comparing pointers instead of version values. This caused tools to be removed during platform uninstallation even when another installed platform had a dependency on that tool.
Excellent suggestion @silvanocerza! I have now added an integration test: b13a29c |
Tool dependency by `arduino-cli core uninstall` is somewhat complex because it must only uninstall the tools that no other platforms have a dependency on. If it doesn't, it breaks the other platform and the cause of this breakage would likely not be obvious to the user. So it's important to test to ensure this functionality continues to work correctly.
silvanocerza
approved these changes
Oct 12, 2020
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
Bug fix.
The platform tool dependency check was giving false negatives due to comparing pointers instead of version values.
This caused tools to be removed during platform uninstallation even when another installed platform had a dependency on
that tool.
The
semverpackage'sEqualmethod is used for the comparison, resulting in accurate tool dependency determination.No
Steps to reproduce the bug fixed by this PR:
arduino-cli core uninstall arduino:samdremovesarduino:arm-none-eabi-gcc@7-2017q4, even though it's a dependency of the installedarduino-beta:mbedplatform, causing the compilation for any board of that platform to fail.