Fix platform tool dependency determination #1020
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
Bug fix.
The platform tool dependency check was giving false negatives due to comparing pointers instead of version values.
This caused tools to be removed during platform uninstallation even when another installed platform had a dependency on
that tool.
The
semver
package'sEqual
method is used for the comparison, resulting in accurate tool dependency determination.No
Steps to reproduce the bug fixed by this PR:
arduino-cli core uninstall arduino:samd
removesarduino:arm-none-eabi-gcc@7-2017q4
, even though it's a dependency of the installedarduino-beta:mbed
platform, causing the compilation for any board of that platform to fail.