Return nil on program action if an error occurred

arduino · Aug 10, 2021 · c04a3d7 · c04a3d7
1 parent 0c1b993
commit c04a3d7
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/commands/upload/upload.go b/commands/upload/upload.go
@@ -56,7 +56,7 @@ func Upload(ctx context.Context, req *rpc.UploadRequest, outStream io.Writer, er
 
 	pm := commands.GetPackageManager(req.GetInstance().GetId())
 
-	return &rpc.UploadResponse{}, runProgramAction(
+	if err := runProgramAction(
 		pm,
 		sk,
 		req.GetImportFile(),
@@ -70,7 +70,11 @@ func Upload(ctx context.Context, req *rpc.UploadRequest, outStream io.Writer, er
 		outStream,
 		errStream,
 		req.GetDryRun(),
-	)
+	); err != nil {
+		return nil, err
+	}
+
+	return &rpc.UploadResponse{}, nil
 }
 
 // UsingProgrammer FIXMEDOC