Skip to content

Commit

Permalink
[skip changelog] Pin platform versions used in integration tests (#879)
Browse files Browse the repository at this point in the history
This prevents spurious test breakage caused by platform releases. These tests are about the behavior of Arduino CLI itself, not about testing the platform, so the platform should be static. There are certain tests which make sense to do with the latest release of the platforms, and those have been left as is.
  • Loading branch information
per1234 authored Jul 28, 2020
1 parent 678a48b commit 55859ad
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 14 deletions.
28 changes: 15 additions & 13 deletions test/test_compile.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ def test_compile_without_fqbn(run_command):
result = run_command("core update-index")
assert result.ok

# Download latest AVR
result = run_command("core install arduino:avr")
# Install Arduino AVR Boards
result = run_command("core install arduino:avr@1.8.3")
assert result.ok

# Build sketch without FQBN
Expand Down Expand Up @@ -92,8 +92,8 @@ def test_output_flag_default_path(run_command, data_dir, working_dir):
result = run_command("core update-index")
assert result.ok

# Download latest AVR
result = run_command("core install arduino:avr")
# Install Arduino AVR Boards
result = run_command("core install arduino:avr@1.8.3")
assert result.ok

# Create a test sketch
Expand All @@ -114,8 +114,8 @@ def test_compile_with_sketch_with_symlink_selfloop(run_command, data_dir):
result = run_command("core update-index")
assert result.ok

# Download latest AVR
result = run_command("core install arduino:avr")
# Install Arduino AVR Boards
result = run_command("core install arduino:avr@1.8.3")
assert result.ok

sketch_name = "CompileIntegrationTestSymlinkSelfLoop"
Expand Down Expand Up @@ -168,8 +168,8 @@ def test_compile_and_upload_combo(run_command, data_dir, detected_boards):
assert result.ok

# Install required core(s)
result = run_command("core install arduino:avr")
result = run_command("core install arduino:samd")
result = run_command("core install arduino:avr@1.8.3")
result = run_command("core install arduino:samd@1.8.7")
assert result.ok

# Create a test sketch
Expand Down Expand Up @@ -228,8 +228,8 @@ def test_compile_blacklisted_sketchname(run_command, data_dir):
result = run_command("core update-index")
assert result.ok

# Download latest AVR
result = run_command("core install arduino:avr")
# Install Arduino AVR Boards
result = run_command("core install arduino:avr@1.8.3")
assert result.ok

sketch_name = "RCS"
Expand All @@ -251,11 +251,13 @@ def test_compile_without_precompiled_libraries(run_command, data_dir):
url = "https://adafruit.github.io/arduino-board-index/package_adafruit_index.json"
result = run_command("core update-index --additional-urls={}".format(url))
assert result.ok
result = run_command("core install arduino:mbed --additional-urls={}".format(url))
# arduino:mbed 1.1.5 is incompatible with the Arduino_TensorFlowLite library
# see: https://github.com/arduino/ArduinoCore-nRF528x-mbedos/issues/93
result = run_command("core install arduino:[email protected] --additional-urls={}".format(url))
assert result.ok
result = run_command("core install arduino:samd --additional-urls={}".format(url))
result = run_command("core install arduino:samd@1.8.7 --additional-urls={}".format(url))
assert result.ok
result = run_command("core install adafruit:samd --additional-urls={}".format(url))
result = run_command("core install adafruit:samd@1.6.0 --additional-urls={}".format(url))
assert result.ok

# Install pre-release version of Arduino_TensorFlowLite (will be officially released
Expand Down
2 changes: 1 addition & 1 deletion test/test_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def test_core_install_esp32(run_command, data_dir):
url = "https://dl.espressif.com/dl/package_esp32_index.json"
assert run_command("core update-index --additional-urls={}".format(url))
# install 3rd-party core
assert run_command("core install esp32:esp32 --additional-urls={}".format(url))
assert run_command("core install esp32:esp32@1.0.4 --additional-urls={}".format(url))
# create a sketch and compile to double check the core was successfully installed
sketch_path = os.path.join(data_dir, "test_core_install_esp32")
assert run_command("sketch new {}".format(sketch_path))
Expand Down

0 comments on commit 55859ad

Please sign in to comment.