USB CDC: Line Info Per Instance #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Memory usage change @ d0ae34d
Click for full report table
|
|
LGTM! Thank you for the contribution, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the USB line info from being a static variable inside the
Serial_class.Reasoning is that the SAMD chips have enough USB endpoints to allow a second CDC interface. However the current implementation causes both interfaces to share the line info.
Use-Case:
In my current project a MKR Zero is among other things used to act as a Serial-to-USB bridge for two connected serial devices.
The USB host application should be able to change some of the things stored in line info (mainly baudrate, parity and DTR).
These are read from the respective
Serial_object and (on change) are changed on the hardwareSerialconnected to the external device.Without this change it's not possible to have both serial interfaces running on different baudrates etc. Changing it on one of them will change it in both.
I've been using this change for a bit and couldn't notice any issues with this change.