Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UART: restore default buffer size to 256 bytes #651

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

facchinm
Copy link
Member

Fixes #650

@ArduinoBot
Copy link

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/samd/package_samd-b215_index.json

ℹ️ To test this build:

  1. Open the Preferences of the Arduino IDE.
  2. Add the Build URL above in the Additional Boards Manager URLs field, and click OK.
  3. Open the Boards Manager (menu Tools->Board->Board Manager...)
  4. Install Arduino SAMD core - Pull Request UART: restore default buffer size to 256 bytes #651
  5. Select one of the boards under SAMD Pull Request UART: restore default buffer size to 256 bytes #651 in Tools->Board menu
  6. Compile/Upload as usual

@maxgerhardt
Copy link

But then the buffer size is again non-user-overridable?

#ifdef SERIAL_BUFFER_SIZE
#undef SERIAL_BUFFER_SIZE
#endif
#define SERIAL_BUFFER_SIZE 256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in UART buffer size
3 participants