-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the default SPI & I2C pins to match pinout docs #393
Merged
facchinm
merged 1 commit into
arduino:master
from
TedPap:use_default_SPI_I2C_pins_from_pico_pinout
Jan 31, 2022
Merged
Change the default SPI & I2C pins to match pinout docs #393
facchinm
merged 1 commit into
arduino:master
from
TedPap:use_default_SPI_I2C_pins_from_pico_pinout
Jan 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory usage change @ 96ce48c
Click for full report table
Click for full report CSV
|
TedPap
force-pushed
the
use_default_SPI_I2C_pins_from_pico_pinout
branch
from
January 24, 2022 22:17
96ce48c
to
4ccfcda
Compare
Memory usage change @ 4ccfcda
Click for full report table
Click for full report CSV
|
It makes a lot of sense since the documentation now explicitly states they are the "default" port. Thanks! |
Awesome! Thanks for merging this @facchinm. Any idea when the next release is going to be? |
For others: The default I2C is on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default pins for SPI and I2C to match the ones marked as default in the official raspberry pi pico pinout.
This has already been discussed in issue #194 but I couldn't understand if this change was desired or not but I decided to submit it anyways.
I've tested it with I2C and it works. Unfortunately I could not test with SPI.
Please excuse me if I'm missing something when it comes to PRs in this repository. Finally, thank you very much for your hard work on this project.