Portenta camera fixes #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Memory usage change @ 2a05f69
Click for full report table
Click for full report CSV |
* Fix default registers. * Set default registers on reset/boot.
* Fix broken DMA transfer. * Fix timer frequency (was running at 3MHz). * Fix cache issues. * Update API as requested. * Add skip_frames function.
* Use faster baudrate. * Upscale image to VGA for better viewing.
|
@iabdalkader: To test this do I just need to replace the I am fine with the sketches and using MIT Processes. |
Hi, yes, you need to replace camera.cpp, camera.h, himax.cpp and both the Arduino sketch and the Processing sketch. If the high baudrate doesn't work for you try 115200...Note I reverted some of the older registers and force pushed to the branch, so refresh to get the latest update. |
|
Memory usage change @ 13b1372
Click for full report table
Click for full report CSV |
|
Looks great using ubuntu to run processes even with the fast serial speed
. . . Absolute mess, as always, running processes on windows 10 Thanks for your work, I can take this now and run some machine learning programs using EdgeImpulse P.S. Any chance of some lower resolution, (QQQVGA) or cropping functions in the library? |
Great, just keep in mind the API may change I don't know if this PR will get merged as it is.
Looks like it might be reading less than requested, try looping until the whole frame is read or maybe it's overflowing...There were settings for this in Windows, for COM ports FIFO and buffer sizes try increasing it.
Yes more fixes will likely happen in following PRs. |
|
Thanks @iabdalkader I ran an impulse microcontroller detection program and got these results 93% microcontroller using a 48x48 crop. Your new code has made that happen. Thanks so much. |
pnndra
reviewed
Jan 17, 2021
libraries/Portenta_Camera/camera.cpp
Outdated
| camera_frame_ready = 0; | ||
| /* Wait until camera frame is ready : DCMI Frame event */ | ||
| for (uint32_t start = millis(); camera_frame_ready == 0;) { | ||
| __WFI(); |
There was a problem hiding this comment.
here we may want to add a wait for a signal rather than a flag and a WFI
There was a problem hiding this comment.
But it is a wait for interrupt, it should wake up on the first interrupt. Do you have something else in mind ?
libraries/Portenta_Camera/camera.h
Outdated
| uint8_t* snapshot(); | ||
| int start(uint32_t timeout); | ||
| uint8_t* grab(void); | ||
| int grab(uint8_t *buffer, uint32_t timeout=5000); |
There was a problem hiding this comment.
i'd propose to define a videoBuffer object, eventually in the ArduinoCoreAPI repo that could be used to do operations on top of the buffer and that would also allow to perform sanity checks on the passed buffer (for example that is big enough or in the right format).
the videoBuffer class could then be allocated either dynamically or statically and passed to the CameraClass API.
this could also allow the implementation of a V4L like implementation where the user pushes empty VideoBuffers in the CameraClass and pops full buffers when they are available. then the user, after using the frames would return the now empty buffers to the CameraClass
libraries/Portenta_Camera/examples/Envie_camera/Envie_camera.ino
Outdated
Show resolved
Hide resolved
* Fix pixclk polarity. * Update himax registers. * Support QVGA and QQVGA. * add set_framerate() * add standby() for low-power mode.
|
Memory usage change @ 780323e
Click for full report table
Click for full report CSV |
|
@iabdalkader @pnndra @sebromero can you guys check to see if the Portenta Camera works using the M4 Core as well as the M7 Core. These feature would be very useful. My preliminary test says it doesn't but I am checking some more. Here is the inner M4 core error I am getting using the changes of about 5 days ago. |
|
This driver isn't meant to be portable, it can be though. |
|
Memory usage change @ 43baef4
Click for full report table
Click for full report CSV |
|
Thanks @iabdalkader , I merged it (was working perfectly), just changed a couple of APIs for motion detection to follow Arduino style guidelines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:When the sensor enters standby mode after a frame grab, the auto-exposure function does Not update or gets reset, for now I've added that skip_frames() function to run enough frames for auto-exposure to kick in... but I suggest running the sensor in "normal" mode and adding a function to enter low-power standby() when needed.