Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Subtract one from USB_EP_SIZE in USB_SendSpace #5732

Closed
NicoHood opened this issue Dec 16, 2016 · 2 comments
Closed

Revert Subtract one from USB_EP_SIZE in USB_SendSpace #5732

NicoHood opened this issue Dec 16, 2016 · 2 comments

Comments

@NicoHood
Copy link
Contributor

#4864 introduced a bug that rawhid and the gamepad is not working anymore. This was reported by a lot of users now and should be reverted. There are lots of others suggestions to fix this bug, please go another way. This is definitely not the correct way and breaks multiple USB modules. The core should not try to fix CDC module bugs.

More details in the pr above and here: NicoHood/HID#91
@NicoHood NicoHood mentioned this issue Dec 16, 2016
Closed
@NicoHood
Copy link
Contributor Author

NicoHood commented Jan 3, 2017 •
edited
Loading

@facchinm @cmaglie @sandeepmistry People constantly contact me about this issue and I need to tell them to download the very old IDE 1.6.8 or 1.6.9 to fix this issue. Please revert the commit and then think of another fix.

facchinm added a commit to facchinm/Arduino that referenced this issue Jan 4, 2017
@facchinm
[AVR] Send USB ZLP if required
fbb88e6 
Fixes arduino#5732
@facchinm facchinm mentioned this issue Jan 4, 2017
Merged
cmaglie added a commit to facchinm/Arduino that referenced this issue Jan 4, 2017
@cmaglie
[AVR] USB send ZLP when needed
a540126 
See arduino#5732 arduino#4864 arduino#4138 arduino#3946
@mnhpias
Copy link

mnhpias commented Mar 10, 2017

I'm unable to work RawHID.write ,
I changed \libraries\HID\src\SingleReport\RawHID.h in line 50 from #define RAWHID_TX_SIZE RAWHID_SIZE to #define RAWHID_TX_SIZE 63 , then I sent 50 bytes long uint8_t throgh RawHID.write , but pc didn't receive anything . pls help me to make RawHID.write working .

cmaglie added a commit that referenced this issue Mar 16, 2017
@cmaglie
[AVR] USB send ZLP when needed
3c0f26d 
See #5732 #4864 #4138 #3946
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NicoHood @mnhpias