Do not set full flag if remaining size if 0 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeepmistry
force-pushed
the
socket-buffer-full-remaining-only
branch
from
41f60df
to
9ad6817
Compare
|
looks o.k. so far! (however, I could not do many tests) |
|
@michael71 thanks for the update, we've release a new v0.10.0 version that includes the change. Please let us know how your testing goes once you are able to run more tests :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to resolve #86. Without this change the request for the RSSI from the WINC1500 would timeout and return 0, if there was any pending data in sockets (on non-AVR).
@michael71 please try this change out and report your feedback. Branch can be found here: https://github.com/sandeepmistry/WiFi101/tree/socket-buffer-full-remaining-only