enhance(node-fetch): make ReadableStream[Symbol.asyncIterator] `Asy…

…ncIterableIterator` rather than `AsyncIterator` only (#1961)
ardatan · Jan 10, 2025 · 2785c80 · 2785c80
1 parent 6dc3d3f
commit 2785c80
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/.changeset/afraid-lies-nail.md b/.changeset/afraid-lies-nail.md
@@ -0,0 +1,7 @@
+---
+'@whatwg-node/node-fetch': patch
+'@whatwg-node/fetch': patch
+---
+
+`ReadableStream`'s `Symbol.asyncIterator` now returns `AsyncIterableIterator` like before even if it
+is ok to return `AsyncIterator` right now. It is safer to return `AsyncIterableIterator` because it is a common mistake to use `AsyncIterator` as `AsyncIterable`.
diff --git a/packages/node-fetch/src/ReadableStream.ts b/packages/node-fetch/src/ReadableStream.ts
@@ -171,6 +171,9 @@ export class PonyfillReadableStream<T> implements ReadableStream<T> {
   [Symbol.asyncIterator]() {
     const iterator = this.readable[Symbol.asyncIterator]();
     return {
+      [Symbol.asyncIterator]() {
+        return this;
+      },
       next: () => iterator.next(),
       return: () => {
         if (!this.readable.destroyed) {