Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AggregateError errors are GraphQL located errors, not the AggregateError itself #6356

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

enisdenjo
Copy link
Collaborator

@enisdenjo enisdenjo commented Jul 18, 2024

Instead of transforming the AggregateError itself to a GraphQL located error.

This is because of two reasons:

  • AggregateError wont lose the instanceof its class
  • Expanding the AggregateError errors will each contain the proper locations

Copy link

changeset-bot bot commented Jul 18, 2024

🦋 Changeset detected

Latest commit: 1f25458

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-tools/delegate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 18, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 330      ✗ 0  
     data_received..................: 38 MB   3.8 MB/s
     data_sent......................: 141 kB  14 kB/s
     http_req_blocked...............: avg=3.93µs  min=1.88µs   med=2.61µs   max=171.74µs p(90)=3.78µs   p(95)=4.17µs  
     http_req_connecting............: avg=701ns   min=0s       med=0s       max=115.69µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=56.36ms min=49ms     med=53.03ms  max=150.34ms p(90)=60.32ms  p(95)=86.12ms 
       { expected_response:true }...: avg=56.36ms min=49ms     med=53.03ms  max=150.34ms p(90)=60.32ms  p(95)=86.12ms 
     http_req_failed................: 0.00%   ✓ 0        ✗ 165
     http_req_receiving.............: avg=134.7µs min=106.75µs med=129.24µs max=352.32µs p(90)=148.71µs p(95)=160.84µs
     http_req_sending...............: avg=24.78µs min=16.31µs  med=24.71µs  max=59.4µs   p(90)=30.04µs  p(95)=33.05µs 
     http_req_tls_handshaking.......: avg=0s      min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=56.2ms  min=48.86ms  med=52.89ms  max=149.99ms p(90)=60.17ms  p(95)=85.93ms 
     http_reqs......................: 165     16.48617/s
     iteration_duration.............: avg=60.63ms min=52.45ms  med=56.95ms  max=154.46ms p(90)=67.28ms  p(95)=90.12ms 
     iterations.....................: 165     16.48617/s
     vus............................: 1       min=1      max=1
     vus_max........................: 1       min=1      max=1

Copy link
Contributor

github-actions bot commented Jul 18, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/delegate 10.0.14-alpha-20240718125408-1f254587937296241eb62326e217df8027a9c657 npm ↗︎ unpkg ↗︎
@graphql-tools/executor-http 1.1.5-alpha-20240718125408-1f254587937296241eb62326e217df8027a9c657 npm ↗︎ unpkg ↗︎
@graphql-tools/federation 2.1.2-alpha-20240718125408-1f254587937296241eb62326e217df8027a9c657 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Jul 18, 2024

💻 Website Preview

The latest changes are available as preview in: https://4e342b14.graphql-tools.pages.dev

@enisdenjo enisdenjo changed the title Handle syntetic AggregateErrors when merging subgraph results AggregateError errors are GraphQL located errors, not the AggregateError itself Jul 18, 2024
@enisdenjo enisdenjo requested a review from ardatan July 18, 2024 12:53
@ardatan ardatan merged commit 8094c37 into master Jul 18, 2024
30 checks passed
@ardatan ardatan deleted the syntetic-agg-err branch July 18, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants