Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[executors/http] wrap upstream graphql errors in a GraphQLError instance #6299

Merged
merged 7 commits into from
Jul 5, 2024

Conversation

EmrysMyrddin
Copy link
Collaborator

Description

To allow errors to bubble up from upstream to client, errors contained into a valid execution result should be wrapped into an actual GraphQLError instance

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Copy link

changeset-bot bot commented Jun 28, 2024

🦋 Changeset detected

Latest commit: ebb8878

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-tools/executor-http Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 28, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 326       ✗ 0  
     data_received..................: 38 MB   3.8 MB/s
     data_sent......................: 140 kB  14 kB/s
     http_req_blocked...............: avg=4.1µs    min=2.05µs   med=2.78µs   max=170.63µs p(90)=4.13µs   p(95)=4.55µs  
     http_req_connecting............: avg=713ns    min=0s       med=0s       max=116.22µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=57.23ms  min=49.15ms  med=54.34ms  max=149.29ms p(90)=62.81ms  p(95)=86.74ms 
       { expected_response:true }...: avg=57.23ms  min=49.15ms  med=54.34ms  max=149.29ms p(90)=62.81ms  p(95)=86.74ms 
     http_req_failed................: 0.00%   ✓ 0         ✗ 163
     http_req_receiving.............: avg=134.72µs min=109.53µs med=131.01µs max=303.88µs p(90)=147.72µs p(95)=160.36µs
     http_req_sending...............: avg=25.39µs  min=19.87µs  med=25.19µs  max=66.55µs  p(90)=29.5µs   p(95)=34.47µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=57.07ms  min=49.01ms  med=54.18ms  max=148.92ms p(90)=62.62ms  p(95)=86.58ms 
     http_reqs......................: 163     16.210128/s
     iteration_duration.............: avg=61.66ms  min=53.36ms  med=58.25ms  max=153.14ms p(90)=72.79ms  p(95)=90.47ms 
     iterations.....................: 163     16.210128/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

Copy link
Contributor

github-actions bot commented Jun 28, 2024

💻 Website Preview

The latest changes are available as preview in: https://e6355fce.graphql-tools.pages.dev

@ardatan ardatan force-pushed the executors/http/graphql-errors-from-result branch from 2ce69a5 to f78a037 Compare July 5, 2024 12:18
@ardatan ardatan merged commit b0ffac8 into master Jul 5, 2024
2 checks passed
@ardatan ardatan deleted the executors/http/graphql-errors-from-result branch July 5, 2024 12:25
Copy link
Contributor

github-actions bot commented Jul 5, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/executor-http 1.1.1-alpha-20240705122633-ebb8878f043ab76001e9d678260bcb58f8bf6664 npm ↗︎ unpkg ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants