Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: only clone schema once in addMocksToSchema #6201

Merged
merged 2 commits into from
May 21, 2024

Conversation

grxy
Copy link
Contributor

@grxy grxy commented May 20, 2024

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.

Description

This PR adds updateResolversInPlace: true to the call to addResolversToSchema in addMocksToSchema, to prevent large schemas from being cloned twice.

Related #6198

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots/Sandbox (if appropriate/relevant):

N/A

How Has This Been Tested?

  • Added a test that ensures that a new schema is always created by calls to addMocksToSchema, whether or not the resolvers argument is passed.

Test Environment:

  • OS: MacOS
  • @graphql-tools/mock: 9.0.2
  • NodeJS: v20.10.0

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

See #6198 for alternatives considered.

Copy link

changeset-bot bot commented May 20, 2024

🦋 Changeset detected

Latest commit: b91e948

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-tools/mock Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@grxy grxy marked this pull request as ready for review May 20, 2024 18:15
@ardatan ardatan merged commit 9d79b3e into ardatan:master May 21, 2024
29 checks passed
@ardatan
Copy link
Owner

ardatan commented May 21, 2024

Thanks <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants