Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federation: handle shared root fields in optimal way #6188

Merged
merged 3 commits into from
May 17, 2024
Merged

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented May 16, 2024

If two different subschemas have the root field, use the same field to resolve missing fields instead of applying a type merging in advance

See the changesets for the other required changes

Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: 302ba50

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@graphql-tools/delegate Patch
@graphql-tools/utils Patch
@graphql-tools/stitch Patch
@graphql-tools/federation Patch
federation-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 16, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 300       ✗ 0  
     data_received..................: 35 MB   3.5 MB/s
     data_sent......................: 128 kB  13 kB/s
     http_req_blocked...............: avg=5.02µs  min=2.33µs   med=3.01µs   max=234.48µs p(90)=4.58µs   p(95)=5.18µs  
     http_req_connecting............: avg=1.1µs   min=0s       med=0s       max=165.63µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=62.58ms min=51.35ms  med=57.95ms  max=193.3ms  p(90)=75.35ms  p(95)=93.58ms 
       { expected_response:true }...: avg=62.58ms min=51.35ms  med=57.95ms  max=193.3ms  p(90)=75.35ms  p(95)=93.58ms 
     http_req_failed................: 0.00%   ✓ 0         ✗ 150
     http_req_receiving.............: avg=150.3µs min=116.93µs med=142.36µs max=414.22µs p(90)=166.05µs p(95)=216.74µs
     http_req_sending...............: avg=28.46µs min=18.35µs  med=26.07µs  max=134.98µs p(90)=36.49µs  p(95)=39.86µs 
     http_req_tls_handshaking.......: avg=0s      min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=62.4ms  min=51.19ms  med=57.79ms  max=192.75ms p(90)=75.19ms  p(95)=93.41ms 
     http_reqs......................: 150     14.899325/s
     iteration_duration.............: avg=67.09ms min=55.61ms  med=62.46ms  max=200.21ms p(90)=81.55ms  p(95)=99.21ms 
     iterations.....................: 150     14.899325/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

Base automatically changed from provides-support to master May 17, 2024 13:30
Copy link
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/delegate 10.0.11-alpha-20240517135643-302ba506c04c6e74f9caff133b380c5daa765d8f npm ↗︎ unpkg ↗︎
@graphql-tools/federation 1.1.36-alpha-20240517135643-302ba506c04c6e74f9caff133b380c5daa765d8f npm ↗︎ unpkg ↗︎
@graphql-tools/stitch 9.2.9-alpha-20240517135643-302ba506c04c6e74f9caff133b380c5daa765d8f npm ↗︎ unpkg ↗︎
@graphql-tools/utils 10.2.1-alpha-20240517135643-302ba506c04c6e74f9caff133b380c5daa765d8f npm ↗︎ unpkg ↗︎

@ardatan ardatan merged commit e10c13a into master May 17, 2024
29 checks passed
@ardatan ardatan deleted the shared-root branch May 17, 2024 13:57
Copy link
Contributor

💻 Website Preview

The latest changes are available as preview in: https://0eb0ee46.graphql-tools.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants