Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addResolversToSchema): continue processing all types and fields in edge cases #4355

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

yaacovCR
Copy link
Collaborator

@yaacovCR yaacovCR commented Mar 30, 2022

In previous versions, if requireResolversToMatchSchema was set to ignore, although no error would be thrown for an unexpected resolver type, type processing would still be aborted early. This fix changes the behavior to correctly continue resolver type processing with the next provided type.

In previous versions, if a resolver field began with double underscores, it would correctly be used for legacy behavior to directly set a type property, but field processing would be aborted early. This fix changes the behavior to correctly continue type processing with the next field.

#3096

@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2022

🦋 Changeset detected

Latest commit: 444e6ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@graphql-tools/schema Patch
@graphql-tools/batch-delegate Patch
@graphql-tools/delegate Patch
graphql-tools Patch
@graphql-tools/load Patch
@graphql-tools/mock Patch
@graphql-tools/stitch Patch
@graphql-tools/stitching-directives Patch
@graphql-tools/wrap Patch
@graphql-tools/links Patch
@graphql-tools/url-loader Patch
@graphql-tools/node-require Patch
federation-benchmark Patch
@graphql-tools/prisma-loader Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 30, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/theguild/graphql-tools/EdE6PhnZeJAupHGzSrWeVSkQ1tfz
✅ Preview: Failed

[Deployment for 444e6ea failed]

@yaacovCR yaacovCR changed the title don't break fix(addResolversToSchema): continue processing all types and fields in edge cases Mar 30, 2022
@theguild-bot
Copy link
Collaborator

theguild-bot commented Mar 30, 2022

The latest changes of this PR are available as alpha in npm (based on the declared changesets):

@graphql-tools/[email protected]
@graphql-tools/[email protected]
[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]

@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 220       ✗ 0  
     data_received..................: 26 MB   2.5 MB/s
     data_sent......................: 94 kB   9.3 kB/s
     http_req_blocked...............: avg=7.4µs    min=3.1µs   med=4µs      max=325.72µs p(90)=4.9µs    p(95)=5.31µs  
     http_req_connecting............: avg=2.01µs   min=0s      med=0s       max=221.51µs p(90)=0s       p(95)=0s      
   ✓ http_req_duration..............: avg=84.78ms  min=68.29ms med=79.77ms  max=211.48ms p(90)=95.39ms  p(95)=120.46ms
       { expected_response:true }...: avg=84.78ms  min=68.29ms med=79.77ms  max=211.48ms p(90)=95.39ms  p(95)=120.46ms
     http_req_failed................: 0.00%   ✓ 0         ✗ 110
     http_req_receiving.............: avg=185.12µs min=129.5µs med=174.96µs max=447.72µs p(90)=209.83µs p(95)=258.62µs
     http_req_sending...............: avg=102.21µs min=19.6µs  med=29.15µs  max=2.85ms   p(90)=48.38µs  p(95)=406.63µs
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=84.49ms  min=68.09ms med=79.56ms  max=210.93ms p(90)=95.19ms  p(95)=120.23ms
     http_reqs......................: 110     10.907147/s
     iteration_duration.............: avg=91.64ms  min=73.9ms  med=86.96ms  max=219.87ms p(90)=104.68ms p(95)=127.65ms
     iterations.....................: 110     10.907147/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

@ardatan ardatan merged commit 722abad into master Mar 30, 2022
@ardatan ardatan deleted the fix-break branch March 30, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants