Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7 #1935

Merged
merged 68 commits into from
Oct 23, 2020
Merged

v7 #1935

merged 68 commits into from
Oct 23, 2020

Commits on Oct 22, 2020

  1. fix(errors): preserve merged paths

    This is not the optimal way to address #1047 but is the most backwards
    compatible.
    yaacovCR committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    b7fa0dd View commit details
    Browse the repository at this point in the history
  2. refactor(Transform): move type to delegate package

    includes also changes to transform method arguments
    see #1614
    yaacovCR committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    6dba0d0 View commit details
    Browse the repository at this point in the history
  3. fix(pruning): remove implicit pruning

    * implicit pruning from healSchema and mapSchema can sometimes be dangerous: e.g.  empty interfaces are valid for later extension.
    * the pruneSchema utility functions (and PruneSchema transform) can be explicitly used to prune as desired
    
    See: #1817
    yaacovCR committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    c52c3f7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cc9149c View commit details
    Browse the repository at this point in the history
  5. abstract out ExternalData type

    * removes support for createMergedResolver and ExtendSchema transform in favor of visitResult, simplifying the refactoring.
    yaacovCR committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    335296f View commit details
    Browse the repository at this point in the history
  6. prune utils package

    move typesContainSelectionSet to delegate package
    remove typeContainsSelectionSet
    yaacovCR committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    beceb89 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7c24a37 View commit details
    Browse the repository at this point in the history
  8. refactor(errors): proxy all the errors

    Previously, errors with invalid or missing paths were lost.
    See:
    #1641
    https://github.com/apollographql/apollo-server/issues/4226
    
    They are now saved!
    
    All correctly pathed errors are now inlined into the returned data by the CheckResultAndHandleErrors transform.
    
    The data is now annotated only with the remaining "unpathed" errors. These are then returned when possible if a null is encountered including the missing or potentially invalid path.
    
    Changes to error handling obviate some existing functions including getErrorsByPathSegment, getErrors in favor of getUnpathedErrors.
    
    Utility functions including slicedError and unreleased functions extendedError and unextendedError are no longer necessary.
    yaacovCR committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    c17067b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6855277 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    88ac52d View commit details
    Browse the repository at this point in the history
  11. fix type location

    yaacovCR committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    9cf2a50 View commit details
    Browse the repository at this point in the history
  12. fix build

    yaacovCR committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    c54e0d3 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    952ecc9 View commit details
    Browse the repository at this point in the history
  14. add isAsyncIterable

    we could consider later adding support for $$asyncIterable similar to upstream graphql-js, but this would have to be across the entire codebase, which currently supports only Symbol.asyncIterator.
    yaacovCR committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    badef7a View commit details
    Browse the repository at this point in the history
  15. refactor(transforms)

    use delegationContext within delegation transforms
    remove fragment hints and transforms in favor of selection set hints and transforms
    prune fragment functions from utils package
    yaacovCR committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    322ef2e View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    c5ec56a View commit details
    Browse the repository at this point in the history
  17. lint

    yaacovCR committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    813ed78 View commit details
    Browse the repository at this point in the history
  18. fix errors

    yaacovCR committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    ff43e51 View commit details
    Browse the repository at this point in the history
  19. remove schemas property

    yaacovCR committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    8758356 View commit details
    Browse the repository at this point in the history
  20. v7 enhance(utils) expand filterSchema (#2005)

    * updated filter schema.
    
    * update existing usage.
    gmac authored and yaacovCR committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    39562a9 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    6243d70 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    9ed6eca View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    b697c46 View commit details
    Browse the repository at this point in the history
  24. refactor(stitchSchemas): clean up

    = remove schemaLikeObjects in favor of better typed sources
    
    = make sure to retrieve the transformedSubschema stored with the transformedSubschemaConfig
    yaacovCR committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    dcafaa5 View commit details
    Browse the repository at this point in the history
  25. initial changeset

    yaacovCR committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    280d77a View commit details
    Browse the repository at this point in the history
  26. fix(HoistField): allow hoisting to root

    requires passing additional parameters to each transformSchema call beyond the subschemaConfig: the transforms, and the transformedSchema.
    
    Because transformSchema may need to create additional proxying resolvers, it needs all the parameters that would be passed to delegateToSchema.
    
    It is NOT a catch-22 that transformSchema requires the transformed schema as a parameter, because it does NOT require an executable transformedSchema as a parameter, only the non-executable version for type comparisions performed ultimately by delegateToSchema within the proxying process.
    yaacovCR committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    409adbe View commit details
    Browse the repository at this point in the history
  27. integrate review

    yaacovCR committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    bfb9098 View commit details
    Browse the repository at this point in the history
  28. BREAKING_CHANGE: remove custom wrappingResolver option from WrapFields

    This does not make sense in the context of planned functionality to wrap subscription root fields in potentially multiple layers, as the wrapping resolvers will have to be different for the root field and the other layers.
    
    Changing a root field resolver can be easily accomplished in a separate transform via TransformRootFIelds or TransformObjectFIelds.
    yaacovCR committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    24aad24 View commit details
    Browse the repository at this point in the history
  29. prune(Operation type)

    Remove `Operation` type in favor of `OperationTypeNode` from upstream graphql-js
    yaacovCR committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    7c9e58d View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. Configuration menu
    Copy the full SHA
    d8ea58f View commit details
    Browse the repository at this point in the history
  2. fix imports

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    e3040c5 View commit details
    Browse the repository at this point in the history
  3. typo

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    2660da5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    848119e View commit details
    Browse the repository at this point in the history
  5. remove old designs folder

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    42edc2f View commit details
    Browse the repository at this point in the history
  6. clean up v6 migration guide

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    6ee0708 View commit details
    Browse the repository at this point in the history
  7. improve docs

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    3677750 View commit details
    Browse the repository at this point in the history
  8. adjust optionality

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    a29df83 View commit details
    Browse the repository at this point in the history
  9. simplify wrapSchema options

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    0061485 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7827604 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    8e09f8a View commit details
    Browse the repository at this point in the history
  12. move type to types

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    0e6a429 View commit details
    Browse the repository at this point in the history
  13. fix mocks

    resolvers that return 'subresolvers' or fields that are set to functions for later use as resolvers were behaving not according to upstream graphql-js convention, these functions take 3 arguments, not 4, with parent available as this.
    
    See #1807
    See https://github.com/graphql/graphql-js/blob/7e79bbe5f2b0e971b5e5f6fe3e7b19c43dea9f35/src/execution/execute.js#L1210-L1212
    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    ac9f40f View commit details
    Browse the repository at this point in the history
  14. update docs

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    d0304a3 View commit details
    Browse the repository at this point in the history
  15. update changeset

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    3d474b5 View commit details
    Browse the repository at this point in the history
  16. remove unused code

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    7f52da1 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    e482716 View commit details
    Browse the repository at this point in the history
  18. prune StitchingInfo

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    b1e4480 View commit details
    Browse the repository at this point in the history
  19. fix build

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    74c95e8 View commit details
    Browse the repository at this point in the history
  20. further: fix build

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    131fe86 View commit details
    Browse the repository at this point in the history
  21. refactor

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    e910a67 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    5d0dd8b View commit details
    Browse the repository at this point in the history
  23. small refactor

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    cbe7dd3 View commit details
    Browse the repository at this point in the history
  24. fix packages

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    a5c26d5 View commit details
    Browse the repository at this point in the history
  25. provide all the metadata

    includes breaking changes to onTypeConflict, fieldConfigMerger and inputFieldConfigMerger
    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    a36b682 View commit details
    Browse the repository at this point in the history
  26. rename variable

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    fed9d4e View commit details
    Browse the repository at this point in the history
  27. enhance typings

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    de01936 View commit details
    Browse the repository at this point in the history
  28. naming is hard

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    79b828b View commit details
    Browse the repository at this point in the history
  29. update docs

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    35a2eca View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    467e593 View commit details
    Browse the repository at this point in the history
  31. reorder

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    7b9f9f0 View commit details
    Browse the repository at this point in the history
  32. small refactor

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    cd1452a View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    b8e3341 View commit details
    Browse the repository at this point in the history
  34. fix typos

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    9ec00c5 View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    ed2585d View commit details
    Browse the repository at this point in the history
  36. fix(generate): harmonize validators

    see #2103
    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    2c18604 View commit details
    Browse the repository at this point in the history
  37. fix(batching): memoize createDefaultExecutor

    to allow batching when using the default executor
    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    134827d View commit details
    Browse the repository at this point in the history
  38. refactor(endpoint): no longer necessary

    BREAKING CHANGE: batching is now performed (when enabled) for all subschema config objects with identical executors, removing the need for the endpoint abstraction
    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    69ee3cd View commit details
    Browse the repository at this point in the history
  39. Update weak-peaches-count.md

    yaacovCR committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    09822d8 View commit details
    Browse the repository at this point in the history