Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@graphql-hive/gateway] allow header forwarding for WebSocket transport #7712

Merged
merged 7 commits into from
Oct 26, 2024
Merged

[@graphql-hive/gateway] allow header forwarding for WebSocket transport #7712

merged 7 commits into from
Oct 26, 2024

Conversation

EmrysMyrddin
Copy link
Collaborator

@EmrysMyrddin EmrysMyrddin commented Sep 23, 2024 •
edited
Loading

fixes #7673
fixes #6335

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

The build artifacts of mesh-serve as a single executable for macOS-ARM64 are available at:
Download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

The build artifacts of hive-gateway as a single executable for Linux-X64 are available at:
Download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-mesh/fusion-runtime 0.9.6-alpha-20241026113055-d58b8697a64f82eb6a334506b0eb712a22ce24bc npm ↗︎ unpkg ↗︎
@graphql-hive/gateway 1.4.0-alpha-20241026113055-d58b8697a64f82eb6a334506b0eb712a22ce24bc npm ↗︎ unpkg ↗︎
@graphql-mesh/hmac-upstream-signature 1.2.4-alpha-20241026113055-d58b8697a64f82eb6a334506b0eb712a22ce24bc npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-jwt-auth 1.2.4-alpha-20241026113055-d58b8697a64f82eb6a334506b0eb712a22ce24bc npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-opentelemetry 1.3.4-alpha-20241026113055-d58b8697a64f82eb6a334506b0eb712a22ce24bc npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-operation-headers 1.2.4-alpha-20241026113055-d58b8697a64f82eb6a334506b0eb712a22ce24bc npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-prometheus 1.2.4-alpha-20241026113055-d58b8697a64f82eb6a334506b0eb712a22ce24bc npm ↗︎ unpkg ↗︎
@graphql-mesh/serve-cli 1.4.0-alpha-20241026113055-d58b8697a64f82eb6a334506b0eb712a22ce24bc npm ↗︎ unpkg ↗︎
@graphql-mesh/serve-runtime 1.2.4-alpha-20241026113055-d58b8697a64f82eb6a334506b0eb712a22ce24bc npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-http 0.6.12-alpha-20241026113055-d58b8697a64f82eb6a334506b0eb712a22ce24bc npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-ws 0.4.0-alpha-20241026113055-d58b8697a64f82eb6a334506b0eb712a22ce24bc npm ↗︎ unpkg ↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

The build artifacts of hive-gateway as a single executable for macOS-X64 are available at:
Download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

💻 Website Preview

The latest changes are available as preview in: https://3926b744.graphql-mesh.pages.dev

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

The build artifacts of mesh-serve as a single executable for Windows-X64 are available at:
Download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

Published mesh-serve images for this PR are available at:

ghcr.io/ardatan/mesh-serve:1.4.0-alpha-20241026113055-d58b8697a64f82eb6a334506b0eb712a22ce24bc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

Published hive-gateway images for this PR are available at:

ghcr.io/ardatan/hive-gateway:1.4.0-alpha-20241026113055-d58b8697a64f82eb6a334506b0eb712a22ce24bc

enisdenjo
enisdenjo requested changes Sep 25, 2024
View reviewed changes
packages/transports/http/src/index.ts Outdated Show resolved Hide resolved
enisdenjo
enisdenjo requested changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@enisdenjo enisdenjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that the headers can be forwarded now is a changeset too. Would be great to add an example and ideally update the docs.

enisdenjo
enisdenjo requested changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@enisdenjo enisdenjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the stable version bump, this looks good to me!

packages/transports/ws/package.json Outdated Show resolved Hide resolved
@EmrysMyrddin EmrysMyrddin force-pushed the add-ws-to-bundle branch 2 times, most recently from 324615c to 35ac686 Compare September 27, 2024 07:07
@EmrysMyrddin EmrysMyrddin force-pushed the add-ws-to-bundle branch 2 times, most recently from 925c26a to 6dccd8f Compare October 9, 2024 07:00
ardatan
ardatan approved these changes Oct 18, 2024
View reviewed changes
Copy link
Owner

@ardatan ardatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we need tests ?

@enisdenjo
Copy link
Collaborator

@EmrysMyrddin please rebase (again 😅), answer this and then we can land this.

@EmrysMyrddin
Copy link
Collaborator Author

Hummm perhaps we should have tests yes, I'm even kind of surprised I haven't broken any test with my change.
The header propagation is mainly done by graphql-tools, so this part should be ok.
It's more the "caching" thing that should probably be tested.

@EmrysMyrddin EmrysMyrddin requested a review from ardatan October 26, 2024 09:00
@EmrysMyrddin EmrysMyrddin changed the title [@graphql-hive/gateway] add @graphql-mesh/transport-ws to bundle [@graphql-hive/gateway] allow header forwarding for WebSocket transport Oct 26, 2024
@enisdenjo enisdenjo merged commit dc54d58 into master Oct 26, 2024
42 checks passed
@enisdenjo enisdenjo deleted the add-ws-to-bundle branch October 26, 2024 12:00
@theguild-bot theguild-bot mentioned this pull request Oct 26, 2024
Merged
ardatan pushed a commit that referenced this pull request Nov 20, 2024
@EmrysMyrddin @enisdenjo @ardatan
[@graphql-hive/gateway] allow header forwarding for WebSocket transpo…
88933e9 
…rt (#7712)

Co-authored-by: enisdenjo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardatan ardatan Awaiting requested review from ardatan

@enisdenjo enisdenjo Awaiting requested review from enisdenjo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@EmrysMyrddin @enisdenjo @ardatan