Fix generating logger import code and improve documentation #7118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
logger
option was always meant as a path to a file exporting a logger instance not as the logger instance itself - it has to be this way so that code generation works and can correctly load the logger.I've changed the documentation and typing of the
logger
option, as well as fixing the import path similarly to how other imports work (likeadditionalEnvelopPlugins
).Fixes #7107
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I've built the library and used the built artifacts in my project with success - I'd appreciate hints on how to test this better.
Test Environment:
@graphql-mesh/cli
: v0.90.4Checklist:
CONTRIBUTING doc and the
style guidelines of this project
changeset using
yarn changeset
that bumps the version