Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): add missing graphql peer deps #4674

Merged
merged 1 commit into from
Feb 13, 2023
Merged

fix(deps): add missing graphql peer deps #4674

merged 1 commit into from
Feb 13, 2023

Conversation

mhassan1
Copy link
Contributor

Description

This PR adds missing graphql peer dependencies to @graphql-mesh/cross-helpers and json-machete, which will resolve peer dependency warnings on install, e.g.:

➤ YN0002: │ @graphql-mesh/cross-helpers@npm:0.2.6 doesn't provide graphql (p306b4), requested by @graphql-tools/utils
➤ YN0002: │ json-machete@npm:0.15.9 doesn't provide graphql (p9f76e), requested by @graphql-tools/utils

This relates to #2923, although that issue is old and may not be fully resolved by this.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

N/A

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

N/A

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2022

🦋 Changeset detected

Latest commit: 7b1a01e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 104 packages
Name Type
@graphql-mesh/cross-helpers Patch
json-machete Patch
@graphql-mesh/cli Patch
@graphql-mesh/config Patch
@graphql-mesh/http Patch
@graphql-mesh/runtime Patch
@graphql-mesh/store Patch
@graphql-mesh/utils Patch
@graphql-mesh/cache-file Patch
@graphql-mesh/cache-redis Patch
@graphql-mesh/graphql Patch
@graphql-mesh/grpc Patch
@graphql-mesh/json-schema Patch
@graphql-mesh/mysql Patch
@graphql-mesh/neo4j Patch
@graphql-mesh/odata Patch
@graphql-mesh/postgraphile Patch
@graphql-mesh/thrift Patch
@graphql-mesh/tuql Patch
@graphql-mesh/transform-cache Patch
@graphql-mesh/transform-extend Patch
@graphql-mesh/transform-hive Patch
@graphql-mesh/transform-rate-limit Patch
@graphql-mesh/merger-federation Patch
@graphql-mesh/plugin-hive Patch
@graphql-mesh/plugin-live-query Patch
@graphql-mesh/plugin-mock Patch
@graphql-mesh/plugin-newrelic Patch
@graphql-mesh/plugin-operation-field-permissions Patch
@graphql-mesh/plugin-rate-limit Patch
@graphql-mesh/plugin-response-cache Patch
@graphql-mesh/plugin-snapshot Patch
@omnigraph/json-schema Patch
@omnigraph/openapi Patch
@omnigraph/raml Patch
auth0-example Patch
cloudflare-workers Patch
example-gcp Patch
graphql-file-upload-example Patch
grpc-example Patch
grpc-reflection-example Patch
hasura-openbrewery-geodb Patch
hello-world-esm Patch
json-schema-hello-world Patch
covid-mesh Patch
json-schema-example Patch
json-schema-fhir Patch
json-schema-subscriptions Patch
mongoose-example Patch
mysql-employees Patch
mysql-rfam Patch
neo4j-example Patch
nextjs-apollo-example Patch
nextjs-sdk-example Patch
odata-microsoft-graph-example Patch
odata-msgraph-programmatic-ts Patch
odata-msgraph-programmatic Patch
odata-trippin-example Patch
javascript-wiki Patch
typescript-location-weather-example Patch
openapi-stackexchange Patch
openapi-stripe Patch
openapi-subscriptions Patch
openapi-youtrack Patch
openwhisk-example Patch
postgres-geodb-example Patch
programmatic-batching-example Patch
reddit-example Patch
country-info-example Patch
soap-demo Patch
soap-netsuite Patch
spacex-cfw Patch
chinook Patch
thrift-calculator Patch
type-merging-batching-example Patch
federation-gateway Patch
gateway-example Patch
@graphql-mesh/types Patch
@graphql-mesh/openapi Patch
@graphql-mesh/raml Patch
@graphql-mesh/soap Patch
@graphql-mesh/merger-stitching Patch
@graphql-mesh/jit-executor Patch
@graphql-mesh/cache-cfw-kv Patch
@graphql-mesh/cache-localforage Patch
@graphql-mesh/mongoose Patch
@graphql-mesh/transform-encapsulate Patch
@graphql-mesh/transform-federation Patch
@graphql-mesh/transform-filter-schema Patch
@graphql-mesh/transform-hoist-field Patch
@graphql-mesh/transform-naming-convention Patch
@graphql-mesh/transform-prefix Patch
@graphql-mesh/transform-rename Patch
@graphql-mesh/transform-replace-field Patch
@graphql-mesh/transform-resolvers-composition Patch
@graphql-mesh/transform-type-merging Patch
@graphql-mesh/merger-bare Patch
@graphql-mesh/plugin-deduplicate-request Patch
@graphql-mesh/plugin-http-cache Patch
@graphql-mesh/plugin-http-details-extensions Patch
@graphql-mesh/plugin-prometheus Patch
@graphql-mesh/plugin-statsd Patch
@omnigraph/soap Patch
@graphql-mesh/transform-prune Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@theguild-bot theguild-bot mentioned this pull request Oct 13, 2022
@mhassan1
Copy link
Contributor Author

@ardatan May I request a review? I don't think this PR will be controversial.

@mhassan1
Copy link
Contributor Author

@ardatan All tests are passing.

@mhassan1
Copy link
Contributor Author

mhassan1 commented Dec 1, 2022

@ardatan Are you able to take a look at this?

@ardatan ardatan merged commit 9757152 into ardatan:master Feb 13, 2023
@ardatan
Copy link
Owner

ardatan commented Feb 13, 2023

Sorry for late feedback! Thanks!

@Urigo
Copy link
Collaborator

Urigo commented Feb 18, 2023

Thank you @mhassan1 !
What is your twitter and LinkedIn handles if we want to publicly thank you?

@mhassan1
Copy link
Contributor Author

That's not necessary. Thanks for this awesome library!

@theguild-bot theguild-bot mentioned this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants