Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with bare naming-convention #4572

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

santino
Copy link
Contributor

@santino santino commented Sep 22, 2022

Description

This PR fixes two issue happening with bare naming convention transform:

  1. missing arguments when the applied naming-convention resolves to the same name as the original
  2. ENUM values not mapped when the ENUM is wrapped in NonNull type

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2022

🦋 Changeset detected

Latest commit: 4bd5741

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@graphql-mesh/transform-naming-convention Patch
grpc-example Patch
grpc-reflection-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@santino santino force-pushed the fix-bare-namingConvention branch from 2f70663 to 8a39a0e Compare September 27, 2022 17:02
@santino santino changed the title Fix missing arguments on bare naming-convention Fix issues with bare naming-convention Sep 27, 2022
@ardatan ardatan merged commit 5b812fd into ardatan:master Sep 28, 2022
@santino santino deleted the fix-bare-namingConvention branch October 17, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants