-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
additionalResolvers child field arguments aren't passed through to the backend / all fields are requested #1257
Comments
Also, it seems that is requesting every field on the planet from the backend instead of only selecting the fields that are requested. I was wondering if this could be cleaned up in some way, as this chokes the backend? I was already trying to figure out why it was choking when I set the depth to a relatively high value, but that explains it. I'd expect the backend query to only fetch the fields that are actually requested by the query? |
@ardatan Maybe I can help with implementing the feature, but I hit a roadblock, maybe you can help a little bit I can't find any existing tests that test the current additionalResolvers functionality. Maybe you can help me and set up a test? Maybe a small thing: The additionalResolvers are handled in the config package, doesn't seem the right place for such a functionality? |
Co-authored-by: Renovate Bot <[email protected]>
We're very happy what GraphQL Mesh is offering! Thanks for the hard work.
Added the following to my .meshrc.json, this does seem to work:
To fetch the data I can now do:
What I'd expect:
I'd expect the
pageSize: 2
to be passed.What actually happens:
It doesn't pass the argument and returns too many results
The text was updated successfully, but these errors were encountered: