Remove unused trustProxy in the config

ardatan · Aug 2, 2024 · b78fdb4 · b78fdb4
1 parent 63de546
commit b78fdb4
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 20 deletions.
diff --git a/.changeset/rotten-readers-flash.md b/.changeset/rotten-readers-flash.md
@@ -0,0 +1,8 @@
+---
+'@graphql-mesh/cli': minor
+'@graphql-mesh/types': minor
+---
+
+Removed non-functional \`trustProxy\` option in the config schema
+This might cause a non-functional config schemna validation warning
+This change does not have any impact on the functionality of the Mesh
diff --git a/packages/legacy/cli/src/commands/serve/serve.ts b/packages/legacy/cli/src/commands/serve/serve.ts
@@ -54,8 +54,6 @@ export async function serveMesh(
     sslCredentials,
     endpoint: graphqlPath = '/graphql',
     browser = process.env.NODE_ENV?.toLowerCase() !== 'production',
-    // TODO
-    // trustProxy = 'loopback',
   } = rawServeConfig;
 
   const port = portSelectorFn(

diff --git a/packages/legacy/cli/src/commands/serve/yaml-config.graphql b/packages/legacy/cli/src/commands/serve/yaml-config.graphql
@@ -58,11 +58,6 @@ type ServeConfig @md {
   """
   playgroundTitle: String
   """
-  Configure Express Proxy Handling
-  [Learn more](https://expressjs.com/en/guide/behind-proxies.html)
-  """
-  trustProxy: String
-  """
   Enable and define a limit for [Request Batching](https://github.com/graphql/graphql-over-http/blob/main/rfcs/Batching.md)
   """
   batchingLimit: Int

diff --git a/packages/legacy/http/src/index.ts b/packages/legacy/http/src/index.ts
@@ -28,8 +28,6 @@ export function createMeshHTTPHandler<TServerContext>({
     endpoint: graphqlPath = '/graphql',
     batchingLimit,
     healthCheckEndpoint = '/healthcheck',
-    // TODO
-    // trustProxy = 'loopback',
     extraParamNames,
   } = rawServeConfig;
 

diff --git a/packages/legacy/types/src/config-schema.json b/packages/legacy/types/src/config-schema.json
@@ -162,10 +162,6 @@
           "type": "string",
           "description": "Title of GraphiQL Playground"
         },
-        "trustProxy": {
-          "type": "string",
-          "description": "Configure Express Proxy Handling\n[Learn more](https://expressjs.com/en/guide/behind-proxies.html)"
-        },
         "batchingLimit": {
           "type": "integer",
           "description": "Enable and define a limit for [Request Batching](https://github.com/graphql/graphql-over-http/blob/main/rfcs/Batching.md)"

diff --git a/packages/legacy/types/src/config.ts b/packages/legacy/types/src/config.ts
@@ -112,11 +112,6 @@ export interface ServeConfig {
    * Title of GraphiQL Playground
    */
   playgroundTitle?: string;
-  /**
-   * Configure Express Proxy Handling
-   * [Learn more](https://expressjs.com/en/guide/behind-proxies.html)
-   */
-  trustProxy?: string;
   /**
    * Enable and define a limit for [Request Batching](https://github.com/graphql/graphql-over-http/blob/main/rfcs/Batching.md)
    */

diff --git a/website/src/generated-markdown/ServeConfig.generated.md b/website/src/generated-markdown/ServeConfig.generated.md
@@ -26,8 +26,6 @@ This feature can be disabled by passing `false` One of:
   * `String`
   * `Boolean`
 * `playgroundTitle` (type: `String`) - Title of GraphiQL Playground
-* `trustProxy` (type: `String`) - Configure Express Proxy Handling
-[Learn more](https://expressjs.com/en/guide/behind-proxies.html)
 * `batchingLimit` (type: `Int`) - Enable and define a limit for [Request Batching](https://github.com/graphql/graphql-over-http/blob/main/rfcs/Batching.md)
 * `healthCheckEndpoint` (type: `String`) - Endpoint for [Health Check](https://the-guild.dev/graphql/yoga-server/docs/features/health-check)
 * `extraParamNames` (type: `Array of String`) - By default, GraphQL Mesh does not allow parameters in the request body except `query`, `variables`, `extensions`, and `operationName`.