If additionalProperties is basically type: string, ignore (#4274)

ardatan · Aug 14, 2022 · 28651bb · 28651bb
1 parent 90911f4
commit 28651bb
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/packages/json-machete/src/healJSONSchema.ts b/packages/json-machete/src/healJSONSchema.ts
@@ -183,7 +183,11 @@ export async function healJSONSchema(
           if (typeof subSchema.additionalProperties === 'object') {
             delete subSchema.additionalProperties.readOnly;
             delete subSchema.additionalProperties.writeOnly;
-            if (Object.keys(subSchema.additionalProperties).length === 0) {
+            const additionalPropertiesKeys = Object.keys(subSchema.additionalProperties);
+            if (
+              additionalPropertiesKeys.length === 0 ||
+              (additionalPropertiesKeys.length === 1 && subSchema.additionalProperties.type === 'string')
+            ) {
               logger.debug(
                 `${path} has an empty additionalProperties object. So this is invalid. Replacing it with 'true'`
               );