Add support to set chart and plot area color and border #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and plot area. * Add theme arguments chart/plot_border and chart/plot_background.
|
thank you @trekonom and sorry for the delay of a year... |
|
Great and thanks, David. Already guessed that your are way to busy. (; And as a ggplot2 user by heart that wasn't super important for me. :D But being able to create native Excel charts would make my life easier. Then my colleagues and clients can customise the charts themselves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR extends mschart by adding support to set the chart and plot area background fill and border.
The goal is to give users more options to create charts according to existing style guides, layouts or themes.
To this end I added four new theme arguments
chart/plot_backgroundandchart/plot_border.As a use case and application of the new feature the PR also adds
theme_ggplot2()providing a mschart theme inspired by ggplot2::theme_grey andchart_fill_ggplot2()to apply the default ggplot2 hue pal to a mschart. These functions are of course not needed. But I could imagine that having some built-in themes might be a nice feature.Let me know what you think, if you have suggestions for improvements or ...