feat: support podman #358
Merged
feat: support podman #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds support for running service using Podman. There are a few notable changes that were required to enable Podman support, described below. Podman keeps `HostIP` empty instead of using `0.0.0.0`. This behavior required an update to `extractIPPort`. More information in containers/podman#17780. Podman prefers to use fully-qualified container images (i.e., `example.com/foo/bar:latest`) but will perform [short-name aliasing](https://github.com/containers/image/blob/main/docs/containers-registries.conf.5.md#short-name-aliasing) for unqualified container images. When an unqualified image such as `foo/bar:latest` is loaded into a kind cluster it will be stored as `localhost/foo/bar:latest`. Using backticks for command substitution isn't POSIX compatible. Switched the backticks to `$()` instead to support alternative shells (e.g., `/bin/fish`).
|
Thank you for this. I will review in the morning. If I have questions I'll reach out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for running service using Podman. There are a few notable changes that were required to enable Podman support, described below.
Podman keeps
HostIPempty instead of using0.0.0.0. This behavior required an update toextractIPPort. More information in containers/podman#17780.Podman prefers to use fully-qualified container images (i.e.,
example.com/foo/bar:latest) but will perform short-name aliasing for unqualified container images. When an unqualified image such asfoo/bar:latestis loaded into a kind cluster it will be stored aslocalhost/foo/bar:latest.Using backticks for command substitution isn't POSIX compatible. Switched the backticks to
$()instead to support alternative shells (e.g.,/bin/fish).