Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary allocations #68

Merged
merged 4 commits into from
Aug 17, 2023
Merged

Remove unnecessary allocations #68

merged 4 commits into from
Aug 17, 2023

Conversation

AldaronLau
Copy link
Member

While reviewing the code, found some places where extra allocations are being done that don't need to be.

@AldaronLau
Copy link
Member Author

Just realized missed a mut for illumos, gotta add checks for that OS to CI before merging.

@AldaronLau AldaronLau marked this pull request as draft June 28, 2023 03:32
@AldaronLau AldaronLau marked this pull request as ready for review August 17, 2023 21:35
@AldaronLau AldaronLau merged commit 188c446 into stable Aug 17, 2023
@AldaronLau AldaronLau deleted the cleanup-string-new branch August 17, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AldaronLau