Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removed deprecated .AddHttpCorrelation #441

Merged
merged 2 commits into from
Mar 17, 2023
Merged

chore: Removed deprecated .AddHttpCorrelation #441

merged 2 commits into from
Mar 17, 2023

Conversation

Roeland54
Copy link

resolves #308

@netlify
Copy link

netlify bot commented Mar 2, 2023

Deploy Preview for arcus-webapi ready!

Name Link
🔨 Latest commit 798833e
🔍 Latest deploy log https://app.netlify.com/sites/arcus-webapi/deploys/6409d3502e65e900089511b9
😎 Deploy Preview https://deploy-preview-441--arcus-webapi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@stijnmoreels
Copy link
Member

The build is failing bc the integration tests still include the Hierarchical HTTP correlation.

@Roeland54
Copy link
Author

I try to understand what is going on with the integrations tests. So if I understand correctly the deprecated method used hierarchical http correlation but the method that is replacing it is currently using W3C correlation.
So the unit tests that test hierarchical correlation fail now because of that.
So the the hierarchical correlation tests can be removed because this functionality is not supported anymore. And no new tests need to be written because W3C correlation is already covered by tests.

Conclusion I can remove the tests?

@stijnmoreels
Copy link
Member

Conclusion I can remove the tests?

Yes, those specific ones could be removed safely as we have similar tests for the updated HTTP correlation option where the Hierarchical format is specifically set (as in those tests, the updated HTTP correlation options is used where W3C is the default).

@stijnmoreels stijnmoreels merged commit fc14ee6 into arcus-azure:main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove .AddHttpCorrelation Azure Functions extension with general CorrelationInfoOptions
3 participants