Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(❗) feat: add w3c http correlation support #392

Merged
merged 19 commits into from
Oct 20, 2022
Merged

(❗) feat: add w3c http correlation support #392

merged 19 commits into from
Oct 20, 2022

Conversation

stijnmoreels
Copy link
Member

@stijnmoreels stijnmoreels commented Oct 12, 2022 •
edited
Loading

Adds W3C HTTP correlation support with automatic dependency tracking.

Closes #309
Closes #375
Relates to arcus-azure/arcus.observability#468

@netlify
Copy link

netlify bot commented Oct 12, 2022 •
edited
Loading

✅ Deploy Preview for arcus-webapi ready!

Name Link
🔨 Latest commit 381d096
🔍 Latest deploy log https://app.netlify.com/sites/arcus-webapi/deploys/6350e3e0ea2aca000849335f
😎 Deploy Preview https://deploy-preview-392--arcus-webapi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@stijnmoreels stijnmoreels mentioned this pull request Oct 12, 2022
Closed
@stijnmoreels stijnmoreels changed the title feat: add w3c http correlation support (❗) feat: add w3c http correlation support Oct 14, 2022
fgheysels
fgheysels reviewed Oct 14, 2022
View reviewed changes
Copy link
Member

@fgheysels fgheysels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that we will be able to test a preview of this ?

docs/preview/03-Features/correlation-azure-functions.md Outdated Show resolved Hide resolved
docs/preview/03-Features/correlation.md Outdated Show resolved Hide resolved
docs/preview/03-Features/correlation.md Show resolved Hide resolved
src/Arcus.WebApi.Logging.Core/Correlation/HttpCorrelationFormat.cs Outdated Show resolved Hide resolved
@stijnmoreels stijnmoreels removed their assignment Oct 14, 2022
@stijnmoreels
Copy link
Member Author

I believe that we will be able to test a preview of this ?

We can publish a preview to test this, that's right. 👍

@stijnmoreels stijnmoreels removed their assignment Oct 14, 2022
fgheysels
fgheysels approved these changes Oct 17, 2022
View reviewed changes
docs/preview/03-Features/correlation.md Outdated Show resolved Hide resolved
docs/preview/03-Features/correlation.md Show resolved Hide resolved
@fgheysels fgheysels removed their assignment Oct 19, 2022
@stijnmoreels
Copy link
Member Author

Will work on providing something for HTTP triggers, too. 👍
We can review also later with previews of Web API.

@stijnmoreels stijnmoreels merged commit 74bfc55 into arcus-azure:master Oct 20, 2022
@stijnmoreels stijnmoreels deleted the feature/w3c-http-correlation branch October 20, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgheysels fgheysels fgheysels approved these changes

Assignees

@fgheysels fgheysels

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify HttpClient Correlation setup AppInsights is transitioning to W3C TraceContext
2 participants
@stijnmoreels @fgheysels