Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Azure Key Vault secret and vault name validation from Azure Key Vault secret provider #317

Closed
stijnmoreels opened this issue Feb 18, 2022 · 0 comments · Fixed by #324
Closed

Remove Azure Key Vault secret and vault name validation from Azure Key Vault secret provider #317

stijnmoreels opened this issue Feb 18, 2022 · 0 comments · Fixed by #324
Assignees
@stijnmoreels
Labels
azure-key-vault All issues related to Azure Key Vault integration enhancement New feature or request good first issue Good for newcomers
Milestone
v1.7.0

Comments

@stijnmoreels
Copy link
Member

Is your feature request related to a problem? Please describe.
As a continuation of arcus-azure/arcus.observability#287, we should also remove the Azure Key Vault validation on the public methods of the Azure Key Vault secret provider.

Describe the solution you'd like
Remove all the guard regex validations on the Azure Key Vault secret provider, so it solely verify for a non-blank secret name.

Additional context
Original discussion: arcus-azure/arcus.observability#260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stijnmoreels stijnmoreels

Labels
azure-key-vault All issues related to Azure Key Vault integration enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging a pull request may close this issue.

fix: remove az keyvault regex validation on secret & vault names
1 participant
@stijnmoreels