Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove validation on KeyVault names and KeyVault secret names from LogAzureKeyVaultDependency #287

Closed
fgheysels opened this issue Feb 4, 2022 · 0 comments · Fixed by #289
Closed

Remove validation on KeyVault names and KeyVault secret names from LogAzureKeyVaultDependency #287

fgheysels opened this issue Feb 4, 2022 · 0 comments · Fixed by #289
Assignees
@stijnmoreels
Labels
dependencies All issues related to dependencies good first issue Good for newcomers
Milestone
v2.4.0

Comments

@fgheysels
Copy link
Member

The LogAzureKeyVaultDependency extension method on ILogger contains logic where the name of the KeyVault host and the KeyVault secret parameters that are passed in, are validated against the naming restrictions that apply in Azure for KeyVault.

This discussion preceded this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stijnmoreels stijnmoreels

Labels
dependencies All issues related to dependencies good first issue Good for newcomers
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging a pull request may close this issue.

feat: remove az keyvault-specific guards stijnmoreels/arcus.observability
2 participants
@fgheysels @stijnmoreels