-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - add set data factory trigger state #46
Feature - add set data factory trigger state #46
Conversation
Would it be possible to split the current
This makes it more user-friendly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor remarks.
Also don't forget to update the *.psd1-file (FunctionsToExport-property) with the adjusted command-names, as suggested in the comments.
src/Arcus.Scripting.DataFactory/Arcus.Scripting.DataFactory.psm1
Outdated
Show resolved
Hide resolved
src/Arcus.Scripting.DataFactory/Arcus.Scripting.DataFactory.psm1
Outdated
Show resolved
Hide resolved
src/Arcus.Scripting.DataFactory/Arcus.Scripting.DataFactory.psm1
Outdated
Show resolved
Hide resolved
src/Arcus.Scripting.DataFactory/Arcus.Scripting.DataFactory.psm1
Outdated
Show resolved
Hide resolved
Co-authored-by: Maxim Braekman <[email protected]>
Co-authored-by: Maxim Braekman <[email protected]>
Co-authored-by: Maxim Braekman <[email protected]>
Co-authored-by: Maxim Braekman <[email protected]>
Co-authored-by: Maxim Braekman <[email protected]>
Co-authored-by: Maxim Braekman <[email protected]>
Co-authored-by: Maxim Braekman <[email protected]>
Co-authored-by: Maxim Braekman <[email protected]>
Co-authored-by: Maxim Braekman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just added a few suggestions.
Would it be possible to split the current
Set-AzDataFactoryTriggerState
into 2 separate commands:
Start-AzDataFactoryTrigger
Stop-AzDataFactoryTrigger
This makes it more user-friendly.
Shouldn't this be more Enable
& Disable
@mbraekman?
@tomkerkhove : I was asking myself the same question yesterday, regarding the Guess we'll be using more of enable/disable throughout other scripts as well, so let's make it consistent and go for enable/disable throughout the repo. @stijnmoreels: |
The built-in ones have always confused me because it makes me feel like I'm triggering the pipelines instead of enabling/disabling 😅 |
Yes, will do. |
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some final remainders of the start/stop-rename to enable/disable.
But other than that, looks good to me!
Approving this, so you can go ahead and merge once those last items are ticked off.
src/Arcus.Scripting.DataFactory/Arcus.Scripting.DataFactory.psm1
Outdated
Show resolved
Hide resolved
src/Arcus.Scripting.DataFactory/Arcus.Scripting.DataFactory.psm1
Outdated
Show resolved
Hide resolved
Co-authored-by: Maxim Braekman <[email protected]>
Co-authored-by: Maxim Braekman <[email protected]>
Co-authored-by: Maxim Braekman <[email protected]>
Co-authored-by: Maxim Braekman <[email protected]>
Co-authored-by: Maxim Braekman <[email protected]>
Co-authored-by: Maxim Braekman <[email protected]>
Aha! Thanks, with all this renaming was slipped through 😅 . |
Closes #18