Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce MaximumFollowNextPageLink option for usage with Get-AzLogicAppRunHistory #396

Conversation

pim-simons
Copy link
Contributor

@pim-simons pim-simons commented Jul 1, 2023

Introduce MaximumFollowNextPageLink option in the config file for the Disable-AzLogicAppsFromConfig script.
This prevents retrieving all Logic App runs which can take a very long time.

If the value is not supplied in the config file a default of 10 is used, 30 results are returned per call, so the default will return a max of 300 Logic App runs, which should be enough for most use-cases I think.

As mentioned here #395

@pim-simons pim-simons added enhancement New feature or request area:logic-apps All issues related to Azure Logic Apps labels Jul 1, 2023
@pim-simons pim-simons requested a review from stijnmoreels as a code owner July 1, 2023 11:17
@netlify
Copy link

netlify bot commented Jul 1, 2023

Deploy Preview for arcus-scripting canceled.

Name Link
🔨 Latest commit 397cc66
🔍 Latest deploy log https://app.netlify.com/sites/arcus-scripting/deploys/64a26f639a7fdd00082cce54

Copy link
Member

@stijnmoreels stijnmoreels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again great stuff, descriptive tests with clear inputs. Super. 🎉

@stijnmoreels
Copy link
Member

We can indeed, like you said, create a fix-release for this.
Thx for handling this issue, Pim!

@pim-simons pim-simons changed the title feat: Introduce MaximumFollowNextPageLink option for Disable-AzLogicAppsFromConfig feat: Introduce MaximumFollowNextPageLink option for usage with Get-AzLogicAppRunHistory Jul 3, 2023
Copy link
Member

@stijnmoreels stijnmoreels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@pim-simons pim-simons merged commit 1b281cb into arcus-azure:main Jul 3, 2023
@pim-simons pim-simons deleted the feature/logic-app-follownextpagelink-max branch July 3, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logic-apps All issues related to Azure Logic Apps enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants