chore: remove all module #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for arcus-scripting canceled.
|
|
What do you think, Pim? Could we agree on removing this? |
pim-simons
approved these changes
Dec 30, 2022
I agree, I don't see any use-case for this and personally never used the |
|
I do see the tests failing though |
pim-simons
requested changes
Dec 30, 2022
|
Ah, was a bit too hasty with removing the |
pim-simons
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't have a lot of modules in the beginning, but now there are so many that an
.Allmodule encapsulating everything becomes rather tedious instead of helpful.Closes #347