Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: streamline logging across modules #351

Merged

Conversation

stijnmoreels
Copy link
Member

Streamline logging and level across Powershell modules from Arcus.Scripting.AzureActiveDirectory to Arcus.Scripting.LogicApps, alphabetically.

Relates to #155

@netlify
Copy link

netlify bot commented Dec 26, 2022

Deploy Preview for arcus-scripting canceled.

Name Link
🔨 Latest commit e33076b
🔍 Latest deploy log https://app.netlify.com/sites/arcus-scripting/deploys/63aa97fdf83a260007557b7b

Copy link
Contributor

@pim-simons pim-simons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍🏻
We should probably also update the docs as the logging has changed, for example https://scripting.arcus-azure.net/Features/powershell/azure-logic-apps#disable-an-azure-logic-app states:

PS> Disable-AzLogicApp -ResourceGroupName "rg-common-dev" -LogicAppName "rcv-shopping-order-sftp"
# Access-token and subscriptionId retrieved
# Attempting to disable rcv-shopping-order-sftp

# Successfully disabled rcv-shopping-order-sftp

And that is not correct anymore after this PR.

@stijnmoreels
Copy link
Member Author

We should probably also update the docs as the logging has changed,

Yes, I was thinking about that. Maybe we should not have the 'exact' logging in the docs as it would be rather hard/tedious to get them up-to-date all the time. Maybe we can only include a truncated version of information-like/successful messages?

@stijnmoreels stijnmoreels removed this from the v0.8.0 milestone Dec 26, 2022
@pim-simons
Copy link
Contributor

We should probably also update the docs as the logging has changed,

Yes, I was thinking about that. Maybe we should not have the 'exact' logging in the docs as it would be rather hard/tedious to get them up-to-date all the time. Maybe we can only include a truncated version of information-like/successful messages?

I get your point, but I honestly quite like the way we have it setup in the docs right now, it shows you exactly what to expect which I really like.

@stijnmoreels
Copy link
Member Author

Now, it is updated with the full correct information/success messages.

Copy link
Contributor

@pim-simons pim-simons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🥇

@pim-simons pim-simons merged commit 2cc19b9 into arcus-azure:main Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants