-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: streamline logging across modules #351
chore: streamline logging across modules #351
Conversation
✅ Deploy Preview for arcus-scripting canceled.
|
This reverts commit 5efe387.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍🏻
We should probably also update the docs as the logging has changed, for example https://scripting.arcus-azure.net/Features/powershell/azure-logic-apps#disable-an-azure-logic-app states:
PS> Disable-AzLogicApp -ResourceGroupName "rg-common-dev" -LogicAppName "rcv-shopping-order-sftp"
# Access-token and subscriptionId retrieved
# Attempting to disable rcv-shopping-order-sftp
# Successfully disabled rcv-shopping-order-sftp
And that is not correct anymore after this PR.
src/Arcus.Scripting.ActiveDirectory/Scripts/Add-AzADAppRoleAssignment.ps1
Outdated
Show resolved
Hide resolved
src/Arcus.Scripting.LogicApps/Scripts/Disable-AzLogicAppsFromConfig.ps1
Outdated
Show resolved
Hide resolved
Yes, I was thinking about that. Maybe we should not have the 'exact' logging in the docs as it would be rather hard/tedious to get them up-to-date all the time. Maybe we can only include a truncated version of information-like/successful messages? |
…ignment.ps1 Co-authored-by: Pim Simons <[email protected]>
…onfig.ps1 Co-authored-by: Pim Simons <[email protected]>
I get your point, but I honestly quite like the way we have it setup in the docs right now, it shows you exactly what to expect which I really like. |
Now, it is updated with the full correct information/success messages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🥇
Streamline logging and level across Powershell modules from
Arcus.Scripting.AzureActiveDirectory
toArcus.Scripting.LogicApps
, alphabetically.Relates to #155