Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Provide script to upload agreements into an Integration Account #265

Merged
merged 11 commits into from
Jan 14, 2022
Merged

feat: Provide script to upload agreements into an Integration Account #265

merged 11 commits into from
Jan 14, 2022

Conversation

pim-simons
Copy link
Contributor

Added a script to upload agreements into an Integration Account.

Closes #163

@netlify
Copy link

netlify bot commented Jan 14, 2022 •
edited
Loading

✔️ Deploy Preview for arcus-scripting canceled.

🔨 Explore the source changes: a0e0a7f

🔍 Inspect the deploy log: https://app.netlify.com/sites/arcus-scripting/deploys/61e17fea54e57a0008696b88

@pim-simons pim-simons mentioned this pull request Jan 14, 2022
Closed
stijnmoreels
stijnmoreels approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@stijnmoreels stijnmoreels left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Minor questions/suggestions.

src/Arcus.Scripting.IntegrationAccount/Scripts/Set-AzIntegrationAccountAgreements.ps1 Outdated Show resolved Hide resolved
src/Arcus.Scripting.Tests.Integration/Arcus.Scripting.IntegrationAccount.tests.ps1 Show resolved Hide resolved
src/Arcus.Scripting.Tests.Integration/Arcus.Scripting.IntegrationAccount.tests.ps1 Show resolved Hide resolved
src/Arcus.Scripting.Tests.Unit/Arcus.Scripting.IntegrationAccount.tests.ps1 Show resolved Hide resolved
src/Arcus.Scripting.IntegrationAccount/Scripts/Set-AzIntegrationAccountAgreements.ps1 Show resolved Hide resolved
src/Arcus.Scripting.IntegrationAccount/Scripts/Set-AzIntegrationAccountAgreements.ps1 Outdated Show resolved Hide resolved
src/Arcus.Scripting.IntegrationAccount/Scripts/Set-AzIntegrationAccountAgreements.ps1 Outdated Show resolved Hide resolved
src/Arcus.Scripting.IntegrationAccount/Scripts/Set-AzIntegrationAccountAgreements.ps1 Outdated Show resolved Hide resolved
src/Arcus.Scripting.IntegrationAccount/Scripts/Set-AzIntegrationAccountAgreements.ps1 Show resolved Hide resolved
src/Arcus.Scripting.IntegrationAccount/Scripts/Set-AzIntegrationAccountAgreements.ps1 Show resolved Hide resolved
stijnmoreels
stijnmoreels approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@stijnmoreels stijnmoreels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some stubbed objects in the unit tests are yet correct, but LGTM otherwise. 💯

src/Arcus.Scripting.Tests.Unit/Arcus.Scripting.IntegrationAccount.tests.ps1 Show resolved Hide resolved
stijnmoreels
stijnmoreels approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@stijnmoreels stijnmoreels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe if we're being super paranoid, we could benefit from tests to verify if the sub-types properties, guestIdentity are $null, but otherwise, I think we're good to go! 👍

Feel free to merge when you think you're done.

@pim-simons pim-simons merged commit afb37ed into arcus-azure:master Jan 14, 2022
@pim-simons pim-simons deleted the feature/integration-account-agreements branch January 14, 2022 14:38
@pim-simons pim-simons mentioned this pull request Jan 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stijnmoreels stijnmoreels stijnmoreels approved these changes

@mbraekman mbraekman Awaiting requested review from mbraekman

Assignees

@pim-simons pim-simons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide script to upload agreements into an Integration Account
2 participants
@pim-simons @stijnmoreels