feat: Provide script to upload assemblies into an Integration Account #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for arcus-scripting ready! 🔨 Explore the source changes: 7863ca1 🔍 Inspect the deploy log: https://app.netlify.com/sites/arcus-scripting/deploys/61cc59601910ba0007fb2cfa 😎 Browse the preview: https://deploy-preview-257--arcus-scripting.netlify.app |
stijnmoreels
approved these changes
Dec 29, 2021
There was a problem hiding this comment.
Wel... wauw, bit blown away with how you got all the stuff (code, tests, docs) right. Great testing of the script, btw. Feels very reliable and safe.
Some miner remarks on my side. Also, I created an PR #248 that also removes the tabs in the unit tests file, so we probably will have some merge conflicts, but no worries 😉 .
Great job!
src/Arcus.Scripting.IntegrationAccount/Scripts/Set-AzIntegrationAccountAssemblies.ps1
Outdated
Show resolved
Hide resolved
src/Arcus.Scripting.IntegrationAccount/Scripts/Set-AzIntegrationAccountAssemblies.ps1
Show resolved
Hide resolved
src/Arcus.Scripting.IntegrationAccount/Scripts/Set-AzIntegrationAccountAssemblies.ps1
Show resolved
Hide resolved
src/Arcus.Scripting.Tests.Integration/Arcus.Scripting.IntegrationAccount.tests.ps1
Outdated
Show resolved
Hide resolved
src/Arcus.Scripting.Tests.Integration/Arcus.Scripting.IntegrationAccount.tests.ps1
Outdated
Show resolved
Hide resolved
src/Arcus.Scripting.Tests.Unit/Arcus.Scripting.IntegrationAccount.tests.ps1
Outdated
Show resolved
Hide resolved
src/Arcus.Scripting.Tests.Unit/Arcus.Scripting.IntegrationAccount.tests.ps1
Outdated
Show resolved
Hide resolved
src/Arcus.Scripting.Tests.Unit/Arcus.Scripting.IntegrationAccount.tests.ps1
Outdated
Show resolved
Hide resolved
src/Arcus.Scripting.Tests.Unit/Arcus.Scripting.IntegrationAccount.tests.ps1
Outdated
Show resolved
Hide resolved
src/Arcus.Scripting.Tests.Unit/Arcus.Scripting.IntegrationAccount.tests.ps1
Outdated
Show resolved
Hide resolved
…ionAccount.tests.ps1 Co-authored-by: Stijn Moreels <[email protected]>
…ionAccount.tests.ps1 Co-authored-by: Stijn Moreels <[email protected]>
…ionAccount.tests.ps1 Co-authored-by: Stijn Moreels <[email protected]>
…ionAccount.tests.ps1 Co-authored-by: Stijn Moreels <[email protected]>
…ionAccount.tests.ps1 Co-authored-by: Stijn Moreels <[email protected]>
…ionAccount.tests.ps1 Co-authored-by: Stijn Moreels <[email protected]>
…unt.tests.ps1 Co-authored-by: Stijn Moreels <[email protected]>
…unt.tests.ps1 Co-authored-by: Stijn Moreels <[email protected]>
…unt.tests.ps1 Co-authored-by: Stijn Moreels <[email protected]>
…unt.tests.ps1 Co-authored-by: Stijn Moreels <[email protected]>
…unt.tests.ps1 Co-authored-by: Stijn Moreels <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a script to upload assemblies into an Integration Account, almost entirely based on the already existing scripts to upload schemas and maps into an Integration Account so major props to @mbraekman 🥇
Closes #159