Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: arm inject newline chars on windows #244

Merged

Conversation

stijnmoreels
Copy link
Member

Reverts original newline replacement on Windows that was removed in f41369a.
Harden the integration tests so we check for new line characters.

Closes #242

@netlify
Copy link

netlify bot commented Dec 3, 2021

✔️ Deploy Preview for arcus-scripting canceled.

🔨 Explore the source changes: f6071fc

🔍 Inspect the deploy log: https://app.netlify.com/sites/arcus-scripting/deploys/61a9dbe8e8cc39000a16e2fe

Copy link
Member

@fgheysels fgheysels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the change has just been reverted, and the previous version has been set back ?

@stijnmoreels
Copy link
Member Author

So the change has just been reverted, and the previous version has been set back ?

Yeah, for windows this has been reverted to the same thing we had before v0.5.

@fgheysels
Copy link
Member

So the change has just been reverted, and the previous version has been set back ?

Yeah, for windows this has been reverted to the same thing we had before v0.5.

So we need a followup- PR then or not ?

@stijnmoreels
Copy link
Member Author

So the change has just been reverted, and the previous version has been set back ?

Yeah, for windows this has been reverted to the same thing we had before v0.5.

So we need a followup- PR then or not ?

No, no need, I reverted these changes in this PR.

@stijnmoreels stijnmoreels linked an issue Dec 17, 2021 that may be closed by this pull request
Copy link
Contributor

@pim-simons pim-simons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally had some time to take a look, looks good to me 👍🏻

@stijnmoreels stijnmoreels merged commit 59946d0 into arcus-azure:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants