test: Add integration-tests for Invoke-AzSqlDatabaseMigration

[fgheysels]

Add addition integration tests for Invoke-AzSqlDatabaseMigration

#223

[netlify]

👷 Deploy request for arcus-scripting pending review.
Visit the deploys page to approve it

🔨 Explore the source changes: 8d7b044

[fgheysels]

Integration tests are failing because of a timeout while creating the connection to the Azure SQL database.

Only one of those tests that have a dependency on SQL fail, the other tests succeed. This seems to be due to the fact that 'auto-pause' is enabled on the Azure SQL database that we use to run our tests against.
I think that the amount of time that is required to resume the Azure SQL database exceeds the connection-timeout that is set by default when opening a connection to SQL.

We could workaround this by increasing the connection-timeout in the migrationscript, but maybe that's a bit overkill since it is only needed to make the tests succeed. Don't know if there are any other possibilities ? Maybe add some retry-functionality to the tests ? Or maybe add a 'warmup' section to the tests which is run only once right before our tests execute. In that warmup sequence we just try to open a connection to the DB. This should trigger the Azure SQL database to resume running.

[fgheysels]

Integration tests are failing because of a timeout while creating the connection to the Azure SQL database.

Only one of those tests that have a dependency on SQL fail, the other tests succeed. This seems to be due to the fact that 'auto-pause' is enabled on the Azure SQL database that we use to run our tests against. I think that the amount of time that is required to resume the Azure SQL database exceeds the connection-timeout that is set by default when opening a connection to SQL.

We could workaround this by increasing the connection-timeout in the migrationscript, but maybe that's a bit overkill since it is only needed to make the tests succeed. Don't know if there are any other possibilities ? Maybe add some retry-functionality to the tests ? Or maybe add a 'warmup' section to the tests which is run only once right before our tests execute. In that warmup sequence we just try to open a connection to the DB. This should trigger the Azure SQL database to resume running.

I changed the 'BeforeEach' block to a 'BeforeAll' block, and added a SQL command there which would cause the SQL DB to wake up. Next to that, I also specified a ConnectionTimeout parameter. We'll see if this works out.

[stijnmoreels]

This is already a great addition for the integration tests on the SQL migration script. Very nice! You seem to have solved to problem with the sleeping database too, that's great!
Thanks for taking the time for these tests. It already covers the major pathways we would need to test.

[fgheysels]

Tests are currently failing because a test that failed in the previous run, didn't properly clean up. This should be fixed now. can you try to re-trigger the pipeline @stijnmoreels ?

[tomkerkhove]

/azp run CI - Arcus.Scripting

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[stijnmoreels]

Maybe indeed some description improvements, but otherwise, I think we're ready. Thanks for this! 💯

Oh, and my mention of the false positive remark.

[fgheysels]

Do we need something else before this PR can be merged ?
(I don't have the rights to merge PR's here; can only close it and enable auto-merge -which i've just done but those netlify tasks are still 'waiting' :P -).

@stijnmoreels @tomkerkhove @mbraekman

[stijnmoreels]

Thanks @fgheysels , for your hard work on this! 👍