fix: Provide more graceful handling for APIM default cleanup

[tomkerkhove]

Signed-off-by: Tom Kerkhove [email protected]

Relates to #216

[netlify]

✔️ Deploy Preview for arcus-scripting canceled.

🔨 Explore the source changes: 6b7004b

🔍 Inspect the deploy log: https://app.netlify.com/sites/arcus-scripting/deploys/619373a5a492f50007e949b3

[stijnmoreels]

Should not close this issue, right?

[tomkerkhove]

Yes and no, it will no longer fail if it's not there (based on my basic PowerShell knowledge)

[tomkerkhove]

A unit test failed but I'm new to Pester - Where do I find them and how do I run them?

[stijnmoreels]

Yes and no, it will no longer fail if it's not there (based on my basic PowerShell knowledge)

Hmm, smells like a workaround then, as there's no change in actual operation calls.

[stijnmoreels]

A unit test failed but I'm new to Pester - Where do I find them and how do I run them?

Invoke Pester ./src/Arcus.Scripting.Tests.Unit/Arcus.Scripting.ApiManagement.tests.ps1

Make sure that the .psd1 file of the APIM is having a valid version in the ModuleVersion (instead of the token, like 0.1), otherwise Pester will not be able to read the PS module.
Also: https://github.com/arcus-azure/arcus.scripting/blob/master/CONTRIBUTING.md#how-to-add-tests-for-a-new-script

[tomkerkhove]

Changed it to "Relates to" but we need to fix this

[tomkerkhove]

A unit test failed but I'm new to Pester - Where do I find them and how do I run them?

Invoke Pester ./src/Arcus.Scripting.Tests.Unit/Arcus.Scripting.ApiManagement.tests.ps1

Make sure that the .psd1 file of the APIM is having a valid version in the ModuleVersion (instead of the token, like 0.1), otherwise Pester will not be able to read the PS module. Also: https://github.com/arcus-azure/arcus.scripting/blob/master/CONTRIBUTING.md#how-to-add-tests-for-a-new-script

Looking at the tests it's supposed to return a bool but in the latest version it's only returning an empty object which is the reason of this behavior I think.

Must be a breaking change that slipped in.

[stijnmoreels]

A unit test failed but I'm new to Pester - Where do I find them and how do I run them?

Invoke Pester ./src/Arcus.Scripting.Tests.Unit/Arcus.Scripting.ApiManagement.tests.ps1
Make sure that the .psd1 file of the APIM is having a valid version in the ModuleVersion (instead of the token, like 0.1), otherwise Pester will not be able to read the PS module. Also: https://github.com/arcus-azure/arcus.scripting/blob/master/CONTRIBUTING.md#how-to-add-tests-for-a-new-script

Looking at the tests it's supposed to return a bool but in the latest version it's only returning an empty object which is the reason of this behavior I think.

Must be a breaking change that slipped in.

I don't see any script functions that return booleans, though. If you refering the the stubbed-out functions, those are Azure-specific functions from a dependent module. The tests are failing here because the stubbed-out functions are returning something and the new proposed functionality here assumes that returning something means something's broken.

[tomkerkhove]

I know but that's the new reality, at least in the versions that I have 🤷‍♂️

[stijnmoreels]

Ok, so we may need to change the tests here.

[tomkerkhove]

Unfortunately I won't have the bandwidth to change this so if somebody else could pick this up that would be great.

We also need to check if this is introduced in a given version or not.

[tomkerkhove]

@stijnmoreels As I won't have time to complete this, are you willing to take this over or should I abandon the PR?

[stijnmoreels]

@stijnmoreels As I won't have time to complete this, are you willing to take this over or should I abandon the PR?

Ok, I'll take this up when I got the time (😓).

[tomkerkhove]

It's not urgent and sorry!