feat: Return an object with an empty list property when KV does not exist #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbraekman
reviewed
Apr 27, 2021
| $armAccessPolicies = @() | ||
| $keyVaultAccessPolicies = $keyVault.accessPolicies | ||
| $armAccessPolicies = @() | ||
| $keyVaultAccessPolicies = $keyVault.accessPolicies |
There was a problem hiding this comment.
Any specific reason why you're setting the $keyVaultAccessPolicies-variable outside of the if-statement?
This will only be used within that statement and will remain empty when the $keyVault-variable remains null.
There was a problem hiding this comment.
No, should indeed be put inside the if. I'll change that.
mbraekman
changed the title
mbraekman
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Get-AzKeyVaultAccesspolicies is run against a non existing KV, make sure that the returned object contains a list property which is empty.
By doing so, the return type is consistent with what we get back when the KV does exist.
#166