Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove obsolete message formats #554

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 1 addition & 32 deletions src/Arcus.Observability.Telemetry.Core/MessageFormats.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
using System;
using Arcus.Observability.Telemetry.Core.Logging;

namespace Arcus.Observability.Telemetry.Core
namespace Arcus.Observability.Telemetry.Core
{
/// <summary>
/// Represents the publicly available message formats to track telemetry.
Expand All @@ -13,34 +10,6 @@ public static class MessageFormats
/// </summary>
public const string DependencyFormat = "{@" + ContextProperties.DependencyTracking.DependencyLogEntry + "}";

/// <summary>
/// Gets the message format to log external dependencies without any custom data value (<see cref="ContextProperties.DependencyTracking.DependencyData"/>);
/// compatible with Application Insights 'Dependencies'.
/// </summary>
[Obsolete("Dependencies without data will be logged as '" + nameof(DependencyLogEntry) + "' models instead of this sentence-like format")]
public const string DependencyWithoutDataFormat =
MessagePrefixes.Dependency + " {"
+ ContextProperties.DependencyTracking.DependencyType + "} named {"
+ ContextProperties.DependencyTracking.TargetName + "} in {"
+ ContextProperties.DependencyTracking.Duration + "} at {"
+ ContextProperties.DependencyTracking.StartTime + "} (Successful: {"
+ ContextProperties.DependencyTracking.IsSuccessful + "} - Context: {@"
+ ContextProperties.TelemetryContext + "})";

/// <summary>
/// Gets the message format to log Azure Service Bus dependencies; compatible with Application Insights 'Dependencies'.
/// </summary>
[Obsolete("Dependencies without data will be logged as '" + nameof(DependencyLogEntry) + "' models instead of this sentence-like format")]
public const string ServiceBusDependencyFormat =
MessagePrefixes.Dependency + " {"
+ ContextProperties.DependencyTracking.DependencyType + "} {"
+ ContextProperties.DependencyTracking.ServiceBus.EntityType + "} named {"
+ ContextProperties.DependencyTracking.TargetName + "} in {"
+ ContextProperties.DependencyTracking.Duration + "} at {"
+ ContextProperties.DependencyTracking.StartTime + "} (Successful: {"
+ ContextProperties.DependencyTracking.IsSuccessful + "} - Context: {@"
+ ContextProperties.TelemetryContext + "})";

/// <summary>
/// Gets the message format to log HTTP dependencies; compatible with Application Insights 'Dependencies'.
/// </summary>
Expand Down
Loading