Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not alter telemetry ctx pt.2 #547

Conversation

stijnmoreels
Copy link
Member

Fixes the second set of telemetry extensions w/ a telemetry context that does not alter the original passed-in context. Split in two parts as there are a lot of extensions/tests to be changed.

Relates to #545

@netlify
Copy link

netlify bot commented Oct 26, 2023

Deploy Preview for arcus-observability canceled.

Name Link
🔨 Latest commit bff8ac6
🔍 Latest deploy log https://app.netlify.com/sites/arcus-observability/deploys/653a77158c918e0009cf39ba

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (415964f) 87.50% compared to head (bff8ac6) 87.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
+ Coverage   87.50%   87.77%   +0.26%     
==========================================
  Files          71       71              
  Lines        3081     3067      -14     
  Branches      203      189      -14     
==========================================
- Hits         2696     2692       -4     
  Misses        312      312              
+ Partials       73       63      -10     
Files Coverage Δ
...Core/Extensions/ILoggerHttpDependencyExtensions.cs 98.14% <100.00%> (-0.04%) ⬇️
...tensions/ILoggerAzureSearchDependencyExtensions.cs 100.00% <100.00%> (ø)
...Extensions/ILoggerCosmosSqlDependencyExtensions.cs 100.00% <100.00%> (+1.85%) ⬆️
...re/Extensions/ILoggerCustomDependencyExtensions.cs 100.00% <100.00%> (ø)
...elemetry.Core/Extensions/ILoggerEventExtensions.cs 100.00% <100.00%> (ø)
...Extensions/ILoggerEventHubsDependencyExtensions.cs 100.00% <100.00%> (+2.12%) ⬆️
...xtensions/ILoggerServiceBusDependencyExtensions.cs 100.00% <100.00%> (ø)
....AspNetCore/Extensions/ILoggerRequestExtensions.cs 73.17% <0.00%> (+3.93%) ⬆️
...re/Extensions/ILoggerEventHubsRequestExtensions.cs 97.36% <0.00%> (ø)
...Core/Extensions/ILoggerGeneralRequestExtensions.cs 96.55% <0.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stijnmoreels stijnmoreels merged commit 06ba21d into arcus-azure:main Oct 30, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants