Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove sql project (❗) #520

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

stijnmoreels
Copy link
Member

Remove deprecated SQL project.

Closes #496

@netlify
Copy link

netlify bot commented Jan 20, 2023

Deploy Preview for arcus-observability canceled.

Name Link
🔨 Latest commit dac33af
🔍 Latest deploy log https://app.netlify.com/sites/arcus-observability/deploys/63ca6b993a27ed0008a51b5e

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 86.53% // Head: 86.37% // Decreases project coverage by -0.16% ⚠️

Coverage data is based on head (dac33af) compared to base (00fad63).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
- Coverage   86.53%   86.37%   -0.16%     
==========================================
  Files          77       76       -1     
  Lines        3246     3201      -45     
  Branches      220      220              
==========================================
- Hits         2809     2765      -44     
  Misses        360      360              
+ Partials       77       76       -1     
Impacted Files Coverage Δ
...Core/Extensions/ILoggerHttpDependencyExtensions.cs 98.18% <0.00%> (+0.22%) ⬆️
...Core/Extensions/ILoggerHttpDependencyExtensions.cs 100.00% <0.00%> (+1.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stijnmoreels
Copy link
Member Author

Since the Arcus.Observability.Telemetry.Sql package is made deprecated, we can remove this so we no longer release a version of it.

@stijnmoreels stijnmoreels changed the title chore: remove sql project chore: remove sql project (❗) Jan 20, 2023
Copy link
Member

@fgheysels fgheysels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not remove the files itself as well?

@stijnmoreels
Copy link
Member Author

We do not remove the files itself as well?

Aha, forgot that 😄 Done in dac33af

@stijnmoreels stijnmoreels merged commit 621d22b into arcus-azure:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Arcus.Observability.Telemetry.Sql project
2 participants